DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org, Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Declan Doherty <declan.doherty@intel.com>,
	Radu Nicolau <radu.nicolau@intel.com>
Subject: [PATCH v2 6/7] net/ixgbe: fix missing HW write in IPsec
Date: Wed, 19 Aug 2026 13:32:38 +0100	[thread overview]
Message-ID: <5513a38560b945c19b228ffb017f8f328c85ec46.1787142684.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <cover.1787142684.git.anatoly.burakov@intel.com> <cover.1787142684.git.anatoly.burakov@intel.com>

When removing an SA and finding ourselves with zero refcount on an IP table
entry, we zero out the IP table registers, but do not write them. Add the
missing write.

Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")
Cc: radu.nicolau@intel.com
Cc: stable@dpdk.org

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
---
 drivers/net/intel/ixgbe/ixgbe_ipsec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/intel/ixgbe/ixgbe_ipsec.c
index f026a41690..4fe4dc9ba0 100644
--- a/drivers/net/intel/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/intel/ixgbe/ixgbe_ipsec.c
@@ -318,6 +318,7 @@ ixgbe_crypto_remove_sa(struct ixgbe_crypto_session *ic_session)
 			IXGBE_WRITE_REG(hw, IXGBE_IPSRXIPADDR(1), 0);
 			IXGBE_WRITE_REG(hw, IXGBE_IPSRXIPADDR(2), 0);
 			IXGBE_WRITE_REG(hw, IXGBE_IPSRXIPADDR(3), 0);
+			IXGBE_WAIT_RWRITE;
 		}
 	} else { /* session->dir == RTE_CRYPTO_OUTBOUND */
 		int i;
-- 
2.52.0


  parent reply	other threads:[~2026-08-19 12:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 13:19 [PATCH v1 0/6] IXGBE IPsec fixes Anatoly Burakov
2026-08-18 13:19 ` [PATCH v1 1/6] net/ixgbe: add key length check in IPsec Anatoly Burakov
2026-08-18 13:19 ` [PATCH v1 2/6] net/ixgbe: remove unnecessary dev pointer Anatoly Burakov
2026-08-18 13:19 ` [PATCH v1 3/6] net/ixgbe: harmonize return values in IPsec Anatoly Burakov
2026-08-18 13:19 ` [PATCH v1 4/6] net/ixgbe: get rid of unnecessary malloc " Anatoly Burakov
2026-08-18 13:19 ` [PATCH v1 5/6] net/ixgbe: fix missing HW write " Anatoly Burakov
2026-08-18 13:19 ` [PATCH v1 6/6] net/ixgbe: refactor IPsec code Anatoly Burakov
2026-08-18 16:14 ` [PATCH v1 0/6] IXGBE IPsec fixes Radu Nicolau
2026-08-19 12:32 ` [PATCH v2 0/7] " Anatoly Burakov
2026-08-19 12:32   ` [PATCH v2 1/7] net/ixgbe: add key length check in IPsec Anatoly Burakov
2026-08-19 12:32   ` [PATCH v2 2/7] net/ixgbe: remove unnecessary dev pointer Anatoly Burakov
2026-08-19 12:32   ` [PATCH v2 3/7] net/ixgbe: harmonize return values in IPsec Anatoly Burakov
2026-08-19 12:32   ` [PATCH v2 4/7] net/ixgbe: get rid of unnecessary malloc " Anatoly Burakov
2026-08-19 12:32   ` [PATCH v2 5/7] net/ixgbe: use correct index variable " Anatoly Burakov
2026-08-19 12:52     ` Bruce Richardson
2026-08-19 12:32   ` Anatoly Burakov [this message]
2026-08-19 12:32   ` [PATCH v2 7/7] net/ixgbe: refactor IPsec code Anatoly Burakov
2026-08-19 14:04   ` [PATCH v2 0/7] IXGBE IPsec fixes Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5513a38560b945c19b228ffb017f8f328c85ec46.1787142684.git.anatoly.burakov@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=radu.nicolau@intel.com \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox