From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code Date: Thu, 04 Apr 2019 23:43:24 +0200 Message-ID: <5514293.kQscWdxMbc@xps> References: <20190403142357.17700-1-shreyansh.jain@nxp.com> <20190404072335.24555-2-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shreyansh Jain To: Ferruh Yigit Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D4F931B3D2 for ; Thu, 4 Apr 2019 23:43:27 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/04/2019 23:29, Ferruh Yigit: > On 4/4/2019 8:23 AM, Shreyansh Jain wrote: > > Removes some unused firmware code which was added in last bump > > of the firmware version. No current features uses these APIs. > > > > Signed-off-by: Shreyansh Jain > > <...> > > > diff --git a/drivers/bus/fslmc/mc/fsl_dpci.h b/drivers/bus/fslmc/mc/fsl_dpci.h > > index 9af9097e5..cf3d15267 100644 > > --- a/drivers/bus/fslmc/mc/fsl_dpci.h > > +++ b/drivers/bus/fslmc/mc/fsl_dpci.h > > @@ -108,27 +108,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io, > > uint16_t token, > > struct dpci_attr *attr); > > > > -/** > > - * struct dpci_peer_attr - Structure representing the peer DPCI attributes > > - * @peer_id: DPCI peer id; if no peer is connected returns (-1) > > - * @num_of_priorities: The pper's number of receive priorities; determines the > > - * number of transmit priorities for the local DPCI object > > - */ > > -struct dpci_peer_attr { > > - int peer_id; > > - uint8_t num_of_priorities; > > -}; > > - > > -int dpci_get_peer_attributes(struct fsl_mc_io *mc_io, > > - uint32_t cmd_flags, > > - uint16_t token, > > - struct dpci_peer_attr *attr); > > - > > -int dpci_get_link_state(struct fsl_mc_io *mc_io, > > - uint32_t cmd_flags, > > - uint16_t token, > > - int *up); > > These needs to be removed from .map file too. Removed from master. Thanks for the catch.