From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] kni: fix ethtool build with kernel 4.11
Date: Fri, 05 May 2017 15:46:33 +0200
Message-ID: <5520116.VeCXaXWujL@xps>
References: <20170503160016.31375-1-ferruh.yigit@intel.com>
 <cc0171a5-8a6e-11a6-d8e0-ae4b3fa52c4c@intel.com>
 <48ab36d4-db15-4a46-dc8e-03954ed55452@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, nicolas.dichtel@6wind.com
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C49CA3B5
 for <dev@dpdk.org>; Fri,  5 May 2017 15:46:35 +0200 (CEST)
In-Reply-To: <48ab36d4-db15-4a46-dc8e-03954ed55452@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/05/2017 19:06, Nicolas Dichtel:
> Le 03/05/2017 =C3=A0 18:43, Ferruh Yigit a =C3=A9crit :
> > On 5/3/2017 5:39 PM, Nicolas Dichtel wrote:
> >> Le 03/05/2017 =C3=A0 18:00, Ferruh Yigit a =C3=A9crit :
> >>> build error:
> >>> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10:
> >>> error: implicit declaration of function =E2=80=98pci_enable_msix=E2=
=80=99
> >>> [-Werror=3Dimplicit-function-declaration]
> >>>     err =3D pci_enable_msix(pdev,
> >>>               ^~~~~~~~~~~~~~~
> >>>
> >>> This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config opt=
ion
> >>> enabled.
> >>>
> >>> Following Linux commit removes the pci_enable_msix()
> >>> Linux: 4244de1c64de ("PCI: remove pci_enable_msix")
> >>>
> >>> Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux
> >>> igb driver uses this function.
> >> When looking at the kernel patches, it seems that the way to go is to =
use
> >> pci_alloc_irq_vectors(), but it needs a bit more work.
> >=20
> > I remember this from your igb_uio fix, but latest igb kernel driver uses
> > pci_enable_msix_range(), I found it easy and safe to replicate it.
> Ok.
>=20
> >=20
> > We can update it when kernel igb driver updates the code, unless you
> > have a strong opinion to switch pci_alloc_irq_vectors() in advance?
> No, I don't mind.
>=20
> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Applied, thanks