From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mk: remove make target for examples
Date: Tue, 22 Nov 2016 10:38:39 +0100
Message-ID: <5520615.NhohP7H5Lc@xps13>
References: <1479772058-7112-1-git-send-email-thomas.monjalon@6wind.com>
 <bebe9fe0-3ef7-8800-1a5b-66e8d3b2f21a@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id D80D547D2
 for <dev@dpdk.org>; Tue, 22 Nov 2016 10:38:41 +0100 (CET)
Received: by mail-wm0-f51.google.com with SMTP id t79so14944116wmt.0
 for <dev@dpdk.org>; Tue, 22 Nov 2016 01:38:41 -0800 (PST)
In-Reply-To: <bebe9fe0-3ef7-8800-1a5b-66e8d3b2f21a@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-11-22 00:34, Ferruh Yigit:
> On 11/21/2016 11:47 PM, Thomas Monjalon wrote:
> > The command
> >   make examples
> > works only if target directories have the exact name of configs.
> > 
> > It is more flexible to use
> >   make -C examples RTE_SDK=$(pwd) RTE_TARGET=build
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Instead of removing examples & examples_clean targets, what do you think
> keeping them as wrapper to suggested usage, for backward compatibility.
> 
> Something like:
> "
> BUILDING_RTE_SDK :=
> export BUILDING_RTE_SDK
> 
> # Build directory is given with O=
> O ?= $(RTE_SDK)/examples
> 
> # Target for which examples should be built.
> T ?= build
> 
> .PHONY: examples
> examples:
>         @echo ================== Build examples for $(T)
>         $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T);
> 
> .PHONY: examples_clean
> examples_clean:
>         @echo ================== Clean examples for $(T)
>         $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T) clean;
> "

What is the benefit of this makefile? Just remove -C ?
It is not compatible with the old behaviour, so I'm afraid it would be
confusing for no real benefit.