From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gonzalez Monroy, Sergio" Subject: Re: [PATCH v3 1/5] mk: remove combined library and related options Date: Thu, 09 Apr 2015 09:33:25 +0100 Message-ID: <55263955.1070707@intel.com> References: <1428505645-5578-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1428505645-5578-2-git-send-email-sergio.gonzalez.monroy@intel.com> <20150408112619.14596b65@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Stephen Hemminger Return-path: In-Reply-To: <20150408112619.14596b65@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 08/04/2015 19:26, Stephen Hemminger wrote: > On Wed, 8 Apr 2015 16:07:21 +0100 > Sergio Gonzalez Monroy wrote: > >> Currently, the target/rules to build combined libraries is different >> than the one to build individual libraries. >> >> By removing the combined library option as a build configuration option >> we simplify the build pocess by having a single point for linking/archiving >> libraries in DPDK. >> >> This patch removes CONFIG_RTE_BUILD_COMBINE_LIB build config option and >> removes the makefiles associated with building a combined library. >> >> The CONFIG_RTE_LIBNAME config option is kept as it will be use to >> always generate a linker script that acts as a single combined library. >> >> Signed-off-by: Sergio Gonzalez Monroy > No. We use combined library and it greatly simplfies the application > linking process. > After all the opposition this patch had in v2, I did explain the current issues (see http://dpdk.org/ml/archives/dev/2015-March/015366.html ) and this was the agreed solution. As I mention in the cover letter (also see patch 2/5), building DPDK (after applying this patch series) will always generate a very simple linker script that behaves as a combined library. I encourage you to apply this patch series and try to build your app (which links against combined lib). Your app should build without problem unless I messed up somewhere and it needs fixing. Sergio