From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 3/5] bond mode 4: do not ignore multicast
Date: Fri, 10 Apr 2015 09:56:05 +0200
Message-ID: <55278215.2000702@intel.com>
References: <1428339685-27686-1-git-send-email-ehkinzie@gmail.com>
 <1428339685-27686-4-git-send-email-ehkinzie@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: Eric Kinzie <ehkinzie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1428339685-27686-4-git-send-email-ehkinzie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On 2015-04-06 19:01, Eric Kinzie wrote:

>   			if (unlikely(hdr->ether_type == ether_type_slow_be ||
>   				!collecting || (!promisc &&
> -					!is_same_ether_addr(&bond_mac, &hdr->d_addr)))) {
> +					(!is_multicast_ether_addr(&hdr->d_addr) &&
> +					 !is_same_ether_addr(&bond_mac, &hdr->d_addr))))) {
>

You can drop extra parenthesis here, but beside that I think it is OK.

Should be marked as bugfix.

Acked-by: Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>