From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH] ixgbe: fix build with gcc 4.4 Date: Tue, 14 Apr 2015 15:48:34 +0300 Message-ID: <552D0CA2.9080905@cloudius-systems.com> References: <1429003900-20074-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon , Konstantin Ananyev , Helin Zhang Return-path: In-Reply-To: <1429003900-20074-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 04/14/15 12:31, Thomas Monjalon wrote: > With GCC 4.4.7 from CentOS 6.5, the following errors arise: > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function =E2=80=98ixgbe_dev_rx_qu= eue_setup=E2=80=99: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for= =E2=80=98dev_info.driver_name=E2=80=99) > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function =E2=80=98ixgbe_set_rsc=E2= =80=99: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization for= =E2=80=98dev_info.driver_name=E2=80=99) > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function =E2=80=98ixgbe_recv_pkts= _lro_single_alloc=E2=80=99: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: =E2=80=98next_rsc_entry=E2= =80=99 may be used uninitialized in this function > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: =E2=80=98next_rxe=E2=80=99= may be used uninitialized in this function > > Fixes: 8eecb3295aed ("ixgbe: add LRO support") > > Signed-off-by: Thomas Monjalon > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/i= xgbe_rxtx.c > index f1da9ec..a2b8631 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mb= uf **rx_pkts, uint16_t nb_pkts, > bool eop; > struct ixgbe_rx_entry *rxe; > struct ixgbe_rsc_entry *rsc_entry; > - struct ixgbe_rsc_entry *next_rsc_entry; > - struct ixgbe_rx_entry *next_rxe; > + struct ixgbe_rsc_entry *next_rsc_entry =3D NULL; > + struct ixgbe_rx_entry *next_rxe =3D NULL; > struct rte_mbuf *first_seg; > struct rte_mbuf *rxm; > struct rte_mbuf *nmb; > @@ -2506,7 +2506,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, > struct ixgbe_rx_queue *rxq; > struct ixgbe_hw *hw; > uint16_t len; > - struct rte_eth_dev_info dev_info =3D { 0 }; > + struct rte_eth_dev_info dev_info =3D { .max_rx_queues =3D 0 }; > struct rte_eth_rxmode *dev_rx_mode =3D &dev->data->dev_conf.rxmode; > bool rsc_requested =3D false; > =20 > @@ -4069,7 +4069,7 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) > { > struct rte_eth_rxmode *rx_conf =3D &dev->data->dev_conf.rxmode; > struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_priva= te); > - struct rte_eth_dev_info dev_info =3D { 0 }; > + struct rte_eth_dev_info dev_info =3D { .max_rx_queues =3D 0 }; Hmmm... Unless I miss something this and one above would zero only a=20 single field - "max_rx_queues"; and would leave the rest uninitialized. The original code intend to zero the whole struct. The alternative to=20 the original lines could be usage of memset(). > bool rsc_capable =3D false; > uint16_t i; > uint32_t rdrxctl;