From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH] ixgbe: fix build with gcc 4.4 Date: Tue, 14 Apr 2015 16:41:57 +0300 Message-ID: <552D1925.4090609@cloudius-systems.com> References: <1429003900-20074-1-git-send-email-thomas.monjalon@6wind.com> <552D0D65.6040500@cloudius-systems.com> <2601191342CEEE43887BDE71AB97725821415914@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Ananyev, Konstantin" , Thomas Monjalon , "Zhang, Helin" Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB97725821415914-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 04/14/15 16:23, Ananyev, Konstantin wrote: > >> -----Original Message----- >> From: Vlad Zolotarov [mailto:vladz-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org] >> Sent: Tuesday, April 14, 2015 1:52 PM >> To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin >> Cc: dev-VfR2kkLFssw@public.gmane.org >> Subject: Re: [PATCH] ixgbe: fix build with gcc 4.4 >> >> >> >> On 04/14/15 12:31, Thomas Monjalon wrote: >>> With GCC 4.4.7 from CentOS 6.5, the following errors arise: >>> >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function =E2=80=98ixgbe_dev_rx_= queue_setup=E2=80=99: >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization f= or =E2=80=98dev_info.driver_name=E2=80=99) >>> >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function =E2=80=98ixgbe_set_rsc= =E2=80=99: >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization f= or =E2=80=98dev_info.driver_name=E2=80=99) >>> >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function =E2=80=98ixgbe_recv_pk= ts_lro_single_alloc=E2=80=99: >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: =E2=80=98next_rsc_entr= y=E2=80=99 may be used uninitialized in this function >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: =E2=80=98next_rxe=E2=80= =99 may be used uninitialized in this function >> :D Looks like a gcc bug ;) Both are set and only after that (!!!) used >> under "!eop" condition. > Possibly, but we still need to make it build cleanly. It's clearly - I was just trying to be polite here... ;) Please, add the comment explaining this initialization so that nobody=20 removes these workarounds by mistake... > Konstantin > >>> Fixes: 8eecb3295aed ("ixgbe: add LRO support") >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe= /ixgbe_rxtx.c >>> index f1da9ec..a2b8631 100644 >>> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >>> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >>> @@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_= mbuf **rx_pkts, uint16_t nb_pkts, >>> bool eop; >>> struct ixgbe_rx_entry *rxe; >>> struct ixgbe_rsc_entry *rsc_entry; >>> - struct ixgbe_rsc_entry *next_rsc_entry; >>> - struct ixgbe_rx_entry *next_rxe; >>> + struct ixgbe_rsc_entry *next_rsc_entry =3D NULL; >>> + struct ixgbe_rx_entry *next_rxe =3D NULL; >>> struct rte_mbuf *first_seg; >>> struct rte_mbuf *rxm; >>> struct rte_mbuf *nmb; >>> @@ -2506,7 +2506,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *de= v, >>> struct ixgbe_rx_queue *rxq; >>> struct ixgbe_hw *hw; >>> uint16_t len; >>> - struct rte_eth_dev_info dev_info =3D { 0 }; >>> + struct rte_eth_dev_info dev_info =3D { .max_rx_queues =3D 0 }; >>> struct rte_eth_rxmode *dev_rx_mode =3D &dev->data->dev_conf.rxmod= e; >>> bool rsc_requested =3D false; >>> >>> @@ -4069,7 +4069,7 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) >>> { >>> struct rte_eth_rxmode *rx_conf =3D &dev->data->dev_conf.rxmode; >>> struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_pr= ivate); >>> - struct rte_eth_dev_info dev_info =3D { 0 }; >>> + struct rte_eth_dev_info dev_info =3D { .max_rx_queues =3D 0 }; >>> bool rsc_capable =3D false; >>> uint16_t i; >>> uint32_t rdrxctl;