From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH v2 1/2] ixgbe: fix build with gcc 4.4 Date: Thu, 16 Apr 2015 12:14:45 +0300 Message-ID: <552F7D85.2090002@cloudius-systems.com> References: <1958525.YbKd0lDtje@xps13> <1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable To: Thomas Monjalon , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1429130956-17828-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 04/15/15 23:49, Thomas Monjalon wrote: > With GCC 4.4.7 from CentOS 6.5, the following errors arise: > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function =E2=80=98ixgbe_dev_rx_qu= eue_setup=E2=80=99: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for= =E2=80=98dev_info.driver_name=E2=80=99) > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function =E2=80=98ixgbe_set_rsc=E2= =80=99: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization for= =E2=80=98dev_info.driver_name=E2=80=99) > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function =E2=80=98ixgbe_recv_pkts= _lro_single_alloc=E2=80=99: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: =E2=80=98next_rsc_entry=E2= =80=99 may be used uninitialized in this function > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: =E2=80=98next_rxe=E2=80=99= may be used uninitialized in this function > > The "missing initializer" warning is a GCC bug which seems fixed in 4.7= . > The "may be used uninitialized" warning seems to be another GCC bug and= is > workarounded with NULL initialization. > > Fixes: 8eecb3295aed ("ixgbe: add LRO support") > > Signed-off-by: Thomas Monjalon > --- > changes in v2: > - option -Wno-missing-field-initializers for old GCC instead of code wo= rkaround > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 4 ++-- > mk/toolchain/gcc/rte.vars.mk | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/i= xgbe_rxtx.c > index f1da9ec..6475c44 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mb= uf **rx_pkts, uint16_t nb_pkts, > bool eop; > struct ixgbe_rx_entry *rxe; > struct ixgbe_rsc_entry *rsc_entry; > - struct ixgbe_rsc_entry *next_rsc_entry; > - struct ixgbe_rx_entry *next_rxe; > + struct ixgbe_rsc_entry *next_rsc_entry =3D NULL; > + struct ixgbe_rx_entry *next_rxe =3D NULL; -Wno-maybe-uninitialized ? > struct rte_mbuf *first_seg; > struct rte_mbuf *rxm; > struct rte_mbuf *nmb; > diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.m= k > index 88f235c..208cddd 100644 > --- a/mk/toolchain/gcc/rte.vars.mk > +++ b/mk/toolchain/gcc/rte.vars.mk > @@ -80,5 +80,10 @@ WERROR_FLAGS +=3D -Wundef -Wwrite-strings > # process cpu flags > include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat= .mk > =20 > +# workaround GCC bug with warning "missing initializer" for "=3D {0}" > +ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) > +WERROR_FLAGS +=3D -Wno-missing-field-initializers > +endif > + > export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF > export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS