From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH v9 1/2] mk:Simplify the ifdefs in the makefile
Date: Thu, 14 May 2015 14:30:48 +0200
Message-ID: <55549578.1020009@6wind.com>
References: <1431386066-6147-1-git-send-email-keith.wiles@intel.com>
 <1431534934-15278-1-git-send-email-keith.wiles@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Keith Wiles <keith.wiles@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id D57BD12A8
 for <dev@dpdk.org>; Thu, 14 May 2015 14:30:50 +0200 (CEST)
In-Reply-To: <1431534934-15278-1-git-send-email-keith.wiles@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On 05/13/2015 06:35 PM, Keith Wiles wrote:
> Simplify the ifdefs in rte.app.mk to make the code more
> readable and maintainable by introducing a internal
> _LDLIBS-y variable to build up the LDLIBS variable.
> 
> The new internal variable _LDLIBS-y should not be
> used outside of the rte.app.mk file.
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  mk/rte.app.mk | 243 +++++++++++++++-------------------------------------------
>  1 file changed, 61 insertions(+), 182 deletions(-)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index af8a1b0..1a2043a 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> [...]
>  
> -LDLIBS += $(CPU_LDLIBS)
> +LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS)
>  
>  .PHONY: all
>  all: install


You are still adding EXTRA_LDLIBS in a patch called "simplify the
ifdefs".

A good idea before sending a new version of a patch on the mailing
list is to check the list of the modifications that were discussed.
Then this list can be added in the cover letter or after the "---"
marker of your patch, allowing the reviewers to better understand
what changed in this version.

Regards,
Olivier