Re: Request for Review of Fixes Applied for DPDK 24.11 and 25.11 Compilation Errors

Re: Request for Review of Fixes Applied for DPDK 24.11 and 25.11 Compilation Errors

[Thomas Monjalon]

Hello,

If I understand well, you hit 2 issues while compiling a C++ app linked with DPDK?
Could you share the exact version of your compiler?

For rte_bitops.h, if disabling these macros is OK for you, go with it for now.
We will need to understand what happens exactly with __RTE_BIT_OVERLOAD macros.

For rte_cryptodev.h, it may be hiding an issue somewhere else.
Please could you share the exact error message?



25/03/2026 07:55, Reema Sharma:
> Hi Team,
> 
> Could you please review the attached DPDK patch (dpdk-24.11_patch_for_crypto.patch) and confirm whether the applied fixes are acceptable from the DPDK perspective?
> Your guidance on the correct fix, if any changes are needed, would help us proceed with CU compilation.
> Kindly share an update at your earliest convenience.
> Thanks & Regards,
> Reema Sharma
> ________________________________
> From: Xiong, Tanghong <tanghong.xiong@intel.com>
> Sent: Friday, March 6, 2026 3:26 PM
> To: Zhang, Liheng <liheng.zhang@intel.com>; Reema Sharma <Reema.Sharma@radisys.com>; Liu1, Kai <kai.liu1@intel.com>
> Cc: Prakash Durgapal <Prakash.Durgapal@radisys.com>; Pratap Rana <Pratap.Rana@radisys.com>; Vijay Kumar Mahto <Vijay.Mahto@radisys.com>; Jaydipkumar Dhameliya <Jaydipkumar.Dhameliya@radisys.com>
> Subject: RE: Request for Review of Fixes Applied for DPDK 24.11 and 25.11 Compilation Errors
> 
> 
> Thanks Liheng,
> 
> Just got other info that, you can contact  DPDK directly through this mail: dev@dpdk.org<mailto:dev@dpdk.org>, but the response may be slow.
> 
> 
> 
> BRs,
> 
> Tanghong
> 
> 
> 
> From: Zhang, Liheng <liheng.zhang@intel.com>
> Sent: Friday, March 6, 2026 5:51 PM
> To: Reema Sharma <Reema.Sharma@radisys.com>; Xiong, Tanghong <tanghong.xiong@intel.com>; Liu1, Kai <kai.liu1@intel.com>
> Cc: Durgapal, Prakash <prakash.durgapal@radisys.com>; Pratap Rana <Pratap.Rana@radisys.com>; Vijay Kumar Mahto <Vijay.Mahto@radisys.com>; Jaydipkumar Dhameliya <Jaydipkumar.Dhameliya@radisys.com>
> Subject: RE: Request for Review of Fixes Applied for DPDK 24.11 and 25.11 Compilation Errors
> 
> 
> 
> Yes, there is a file “MAINTAINERS” in the DPDK root path.
> 
> The file list all the contactor for all dpdk libraries.
> 
> You can search and contact the person for crypto issue.
> 
> If you can’t find it, please let me know, I can forward to you.
> 
> 
> 
> From: Reema Sharma <Reema.Sharma@radisys.com<mailto:Reema.Sharma@radisys.com>>
> Sent: Friday, March 6, 2026 5:45 PM
> To: Zhang, Liheng <liheng.zhang@intel.com<mailto:liheng.zhang@intel.com>>; Xiong, Tanghong <tanghong.xiong@intel.com<mailto:tanghong.xiong@intel.com>>; Liu1, Kai <kai.liu1@intel.com<mailto:kai.liu1@intel.com>>
> Cc: Durgapal, Prakash <prakash.durgapal@radisys.com<mailto:prakash.durgapal@radisys.com>>; Pratap Rana <Pratap.Rana@radisys.com<mailto:Pratap.Rana@radisys.com>>; Vijay Kumar Mahto <Vijay.Mahto@radisys.com<mailto:Vijay.Mahto@radisys.com>>; Jaydipkumar Dhameliya <Jaydipkumar.Dhameliya@radisys.com<mailto:Jaydipkumar.Dhameliya@radisys.com>>
> Subject: Re: Request for Review of Fixes Applied for DPDK 24.11 and 25.11 Compilation Errors
> 
> 
> 
> Hi Zhang, Liheng<mailto:liheng.zhang@intel.com>,
> 
> We have verified the behaviour on CU side and confirmed that this is not caused by our code. The issue appears to be related to a DPDK bug.
> 
> At the moment, we do not have any contact information for the DPDK maintainers.
> Could you please check internally and share the relevant maintainer details or forward this issue on behalf of Radisys?
> 
> Thanks & Regards,
> 
> Reema Sharma
> 
> ________________________________
> 
> From: Zhang, Liheng <liheng.zhang@intel.com<mailto:liheng.zhang@intel.com>>
> Sent: Friday, March 6, 2026 2:49 PM
> To: Xiong, Tanghong <tanghong.xiong@intel.com<mailto:tanghong.xiong@intel.com>>; Reema Sharma <Reema.Sharma@radisys.com<mailto:Reema.Sharma@radisys.com>>; Liu1, Kai <kai.liu1@intel.com<mailto:kai.liu1@intel.com>>
> Cc: Prakash Durgapal <Prakash.Durgapal@radisys.com<mailto:Prakash.Durgapal@radisys.com>>; Pratap Rana <Pratap.Rana@radisys.com<mailto:Pratap.Rana@radisys.com>>; Vijay Kumar Mahto <Vijay.Mahto@radisys.com<mailto:Vijay.Mahto@radisys.com>>; Jaydipkumar Dhameliya <Jaydipkumar.Dhameliya@radisys.com<mailto:Jaydipkumar.Dhameliya@radisys.com>>
> Subject: RE: Request for Review of Fixes Applied for DPDK 24.11 and 25.11 Compilation Errors
> 
> 
> 
> The e-mail below is from an external source. Please do not open attachments or click links from an unknown or suspicious origin.
> 
> Hi Reema
> 
> Looks the changes are ok, but you need verify them by compiling your code.
> 
> As I know, the following are the better procedures for DPDK bug fix:
> 
>   1.  Please first confirm the error are not related to your own code before changing DPDK code;
>   2.  If it is real DPDK bug, you need contact the according DPDK maintainer to fix it;
>   3.  Finally DPDK maintainer will provide an official patch;
> 
> 
> 
> From: Xiong, Tanghong <tanghong.xiong@intel.com<mailto:tanghong.xiong@intel.com>>
> Sent: Friday, March 6, 2026 3:52 PM
> To: Reema Sharma <Reema.Sharma@radisys.com<mailto:Reema.Sharma@radisys.com>>; Liu1, Kai <kai.liu1@intel.com<mailto:kai.liu1@intel.com>>; Zhang, Liheng <liheng.zhang@intel.com<mailto:liheng.zhang@intel.com>>
> Cc: Durgapal, Prakash <prakash.durgapal@radisys.com<mailto:prakash.durgapal@radisys.com>>; Pratap Rana <Pratap.Rana@radisys.com<mailto:Pratap.Rana@radisys.com>>; Vijay Kumar Mahto <Vijay.Mahto@radisys.com<mailto:Vijay.Mahto@radisys.com>>; Jaydipkumar Dhameliya <Jaydipkumar.Dhameliya@radisys.com<mailto:Jaydipkumar.Dhameliya@radisys.com>>
> Subject: RE: Request for Review of Fixes Applied for DPDK 24.11 and 25.11 Compilation Errors
> 
> 
> 
> Hello Reema,
> 
> 
> 
> Sorry for late reply, copy @Zhang, Liheng<mailto:liheng.zhang@intel.com> here for comment, thanks Liheng in advance.
> 
> 
> 
> BRs,
> 
> Tanghong
> 
> 
> 
> From: Reema Sharma <Reema.Sharma@radisys.com<mailto:Reema.Sharma@radisys.com>>
> Sent: Friday, March 6, 2026 1:41 PM
> To: Xiong, Tanghong <tanghong.xiong@intel.com<mailto:tanghong.xiong@intel.com>>; Liu1, Kai <kai.liu1@intel.com<mailto:kai.liu1@intel.com>>
> Cc: Durgapal, Prakash <prakash.durgapal@radisys.com<mailto:prakash.durgapal@radisys.com>>; Pratap Rana <Pratap.Rana@radisys.com<mailto:Pratap.Rana@radisys.com>>; Vijay Kumar Mahto <Vijay.Mahto@radisys.com<mailto:Vijay.Mahto@radisys.com>>; Jaydipkumar Dhameliya <Jaydipkumar.Dhameliya@radisys.com<mailto:Jaydipkumar.Dhameliya@radisys.com>>
> Subject: Re: Request for Review of Fixes Applied for DPDK 24.11 and 25.11 Compilation Errors
> 
> 
> 
> Hi Xiong, Tanghong<mailto:tanghong.xiong@intel.com>/ Liu1, Kai<mailto:kai.liu1@intel.com>,
> 
> Hope you are doing well.
> 
> I am writing to check if there is any update on the pending DPDK issue raised in this mail.
> Could you please share the latest status, or let me know if any additional inputs are required from my side to help move this forward?
> 
> Looking forward to your response.
> 
> Thanks & Regards,
> 
> Reema Sharma
> 
> ________________________________
> 
> From: Reema Sharma
> Sent: Wednesday, February 11, 2026 11:27 AM
> To: Xiong, Tanghong <tanghong.xiong@intel.com<mailto:tanghong.xiong@intel.com>>; Liu1, Kai <kai.liu1@intel.com<mailto:kai.liu1@intel.com>>
> Cc: Prakash Durgapal <Prakash.Durgapal@radisys.com<mailto:Prakash.Durgapal@radisys.com>>; Pratap Rana <Pratap.Rana@radisys.com<mailto:Pratap.Rana@radisys.com>>; Vijay Kumar Mahto <Vijay.Mahto@radisys.com<mailto:Vijay.Mahto@radisys.com>>; Jaydipkumar Dhameliya <Jaydipkumar.Dhameliya@radisys.com<mailto:Jaydipkumar.Dhameliya@radisys.com>>
> Subject: Request for Review of Fixes Applied for DPDK 24.11 and 25.11 Compilation Errors
> 
> 
> 
> Hi Xiong, Tanghong<mailto:tanghong.xiong@intel.com>/ Liu1, Kai<mailto:kai.liu1@intel.com>,
> 
> While compiling the CU with DPDK 24.11 and DPDK 25.11, we encountered the following two errors:
> 
>   1.  Conflicting type definitions in the DPDK header file rte_bitops.h
> 
> [cid:image001.png@01DCAD92.9C6111F0]
> 
>   1.  “template with C linkage” error in the DPDK header file rte_cryptodev.h
> 
> To proceed with our CU compilation, we applied the required fixes in the respective DPDK include files and generated a patch named dpdk-24.11_patch_for_crypto.patch. The updated changes are included in the attached patch file for your review.
> 
> Could you please review these changes from the DPDK side and confirm whether they are acceptable, or advise on the correct fix if modifications are required?
> 
> Thanks & Regards,
> Reema Sharma
>