From mboxrd@z Thu Jan  1 00:00:00 1970
From: Declan Doherty <declan.doherty@intel.com>
Subject: Re: bond: mode 4 promiscuous mode
Date: Wed, 20 May 2015 13:34:20 +0100
Message-ID: <555C7F4C.8050208@intel.com>
References: <CAOysbxr30TQ+a7BDHSjd29=3W-Z7V9bYbxcSeyCMZYOLjH=-Ag@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Andriy Berestovskyy <aber@semihalf.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 478F2C320
 for <dev@dpdk.org>; Wed, 20 May 2015 14:28:35 +0200 (CEST)
In-Reply-To: <CAOysbxr30TQ+a7BDHSjd29=3W-Z7V9bYbxcSeyCMZYOLjH=-Ag@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 15/05/15 14:36, Andriy Berestovskyy wrote:
> Hey guys,
> Can we in function bond_mode_8023ad_activate_slave() try to add to the
> slave bond and LACP multicast MACs first? And then we would fall back
> into promiscuous mode if the adding has failed.
>
> In other words:
>
> if (rte_eth_dev_mac_addr_add(slave_id, bond_mac) != 0
>      || rte_eth_dev_mac_addr_add(slave_id, lacp_mac) != 0) {
>      ...
>      rte_eth_promiscuous_enable(slave_id)
> }
>
> Seems to work fine on my setup, but I might miss something.
>
> Regards,
> Andriy
>

Hey Andriy,

that sounds like a sensible idea, if you want to submit your changes in 
a patch or rfc that would be great, I'll have a look and will get them 
tested by our validation team.

Thanks
Declan