From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas F Herbert <therbert@redhat.com>
Subject: Re: [PATCH 4/6] vhost: Add new command line option: rxq
Date: Fri, 22 May 2015 08:51:00 -0400
Message-ID: <555F2634.3040307@redhat.com>
References: <1432194581-15301-1-git-send-email-changchun.ouyang@intel.com>
 <1432194581-15301-5-git-send-email-changchun.ouyang@intel.com>
 <555E88B5.7080906@redhat.com>
 <F52918179C57134FAEC9EA62FA2F962511B5A8C4@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>,
 "dpdk >> dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 10462234
 for <dev@dpdk.org>; Fri, 22 May 2015 14:51:02 +0200 (CEST)
In-Reply-To: <F52918179C57134FAEC9EA62FA2F962511B5A8C4@shsmsx102.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 5/22/15 2:05 AM, Ouyang, Changchun wrote:
> Hi Thomas,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas F Herbert
>> Sent: Friday, May 22, 2015 9:39 AM
>> To: dpdk >> dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 4/6] vhost: Add new command line option:
>> rxq
>>
>>
>>
>> On 5/21/15 3:49 AM, Ouyang Changchun wrote:
>>> Sample vhost need know the queue number user want to enable for each
>>> virtio device, so add the new option '--rxq' into it.
>> Could you also add the new --rxq option description to us_vhost_usage()?
>
> Actually we have, please see below
True enough. However, the code calls rte_eal_init() before parsing args 
and therefore takes rte_exit before printing usage of the non-eal options.
>
>> +585,8 @@
>>> us_vhost_usage(const char *prgname)
>>>    	"		--rx-desc-num [0-N]: the number of descriptors on rx,
>> "
>>>    			"used only when zero copy is enabled.\n"
>>>    	"		--tx-desc-num [0-N]: the number of descriptors on tx,
>> "
>>> -			"used only when zero copy is enabled.\n",
>>> +			"used only when zero copy is enabled.\n"
>>> +	"		--rxq [1,2,4]: rx queue number for each vhost
>> device\n",
>>>    	       prgname);
>>>    }
>
> Thanks
> Changchun
>