From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Boule Subject: Re: [PATCH 0/5] multicast address filtering Date: Fri, 29 May 2015 11:33:54 +0200 Message-ID: <55683282.8020306@6wind.com> References: <1432825523-19006-1-git-send-email-ivan.boule@6wind.com> <20150528092142.7a4241ec@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 433552716 for ; Fri, 29 May 2015 11:33:59 +0200 (CEST) Received: by wgv5 with SMTP id 5so57602198wgv.1 for ; Fri, 29 May 2015 02:33:59 -0700 (PDT) In-Reply-To: <20150528092142.7a4241ec@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/28/2015 06:21 PM, Stephen Hemminger wrote: > On Thu, 28 May 2015 17:05:18 +0200 > Ivan Boule wrote: > >> Introduce PMD API to set the list of multicast MAC addresses filtered >> by a port. >> Implemented in the following PMDs: igb, igbvf, em, ixgbe, and ixgbevf. >> Implementation for physical PMDs i40e, i40evf, enic, and fm10k left >> to their respective maintainers. >> >> Ivan Boule (5): >> ethdev: add multicast address filtering >> app/testpmd: new command to add/remove multicast MAC addresses >> e1000: add multicast MAC address filtering >> ixgbe: add multicast MAC address filtering >> app/testpmd: fix reply to a multicast ICMP request >> >> app/test-pmd/cmdline.c | 52 ++++++++++++++ >> app/test-pmd/config.c | 142 ++++++++++++++++++++++++++++++++++++++ >> app/test-pmd/icmpecho.c | 65 +++++++++++++++-- >> app/test-pmd/testpmd.h | 6 ++ >> drivers/net/e1000/em_ethdev.c | 17 +++++ >> drivers/net/e1000/igb_ethdev.c | 18 +++++ >> drivers/net/ixgbe/ixgbe_ethdev.c | 32 +++++++++ >> lib/librte_ether/rte_ethdev.c | 17 +++++ >> lib/librte_ether/rte_ethdev.h | 26 +++++++ >> 9 files changed, 369 insertions(+), 6 deletions(-) >> > > Looks good, could you also add support for virtio and vmxnet3? > As for physical NICs (i40e, etc.) listed above, I let the maintainers of the remaining NICs where this function is relevant to implement and to test it. By the way, I supposed that Guest front-end vNICs were always in promiscuous mode by construction. Said differently: that all packets supplied "from the outside" to the Host vNIC back-end driver were systematically delivered to the Guest vNIC front-end, whatever their destination MAC address, VLAN id., etc. Did I missed something ?