From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 6/6] doc: remove internal libs from release notes Date: Thu, 25 Oct 2018 02:07:22 +0200 Message-ID: <5568978.q47av0dVMy@xps> References: <20181015145057.37864-1-ferruh.yigit@intel.com> <20181015145057.37864-6-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shreyansh Jain , John McNamara , Marko Kovacevic , "yipeng1.wang@intel.com" , "pablo.de.lara.guarch@intel.com" To: Ferruh Yigit Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 725BB2B94 for ; Thu, 25 Oct 2018 02:07:22 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/10/2018 13:52, Shreyansh Jain: > On Monday 15 October 2018 08:20 PM, Ferruh Yigit wrote: > > These libraries has exported functions but the target of those functions > > are not user but other libraries. > > > > The version of these libraries doesn't mean much to the user so can be > > dropped from release notes. > > > > Signed-off-by: Ferruh Yigit > > --- > > Indeed this is more a question, should we keep them or remove them? > > +1 for removing them. > At least for dpaa/fslmc perspective, I don't see any additional benefit > in release note. These libraries (dpaa/fslmc) are not actually > 'libraries' in true (read, plugability) sense :) > > --- a/doc/guides/rel_notes/release_18_11.rst > > +++ b/doc/guides/rel_notes/release_18_11.rst > > - + librte_bus_dpaa.so.2 > > - + librte_bus_fslmc.so.2 > > - + librte_bus_ifpga.so.2 > > - + librte_bus_pci.so.2 > > - + librte_bus_vdev.so.2 > > - + librte_bus_vmbus.so.2 The ABI of bus libraries is important if you want to plug a PMD into an older DPDK: if bus ABI has changed, you cannot. I am for keeping them. > > - librte_pci.so.1 This is a true library!