From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH v2] mk: remove "u" modifier from "ar" command
Date: Tue, 09 Jun 2015 16:17:37 +0200
Message-ID: <5576F581.3040604@6wind.com>
References: <1433502340-14725-1-git-send-email-bruce.richardson@intel.com>
 <1433854261-9079-1-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id B9C3B5A57
 for <dev@dpdk.org>; Tue,  9 Jun 2015 16:17:43 +0200 (CEST)
Received: by wifx6 with SMTP id x6so18614810wif.0
 for <dev@dpdk.org>; Tue, 09 Jun 2015 07:17:43 -0700 (PDT)
In-Reply-To: <1433854261-9079-1-git-send-email-bruce.richardson@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Bruce,

On 06/09/2015 02:51 PM, Bruce Richardson wrote:
> On Fedora 22, the "ar" binary operates by default in deterministic mode,
> making the "u" parameter irrelevant, and leading to warning messages
> getting printed in the build output like below.
>
>    INSTALL-LIB librte_kvargs.a
> ar: `u' modifier ignored since `D' is the default (see `U')
>
> There are two options to remove these warnings:
> * add in the "U" flag to make "ar" non-deterministic again
> * remove the "u" flag to have all objects always updated
>
> This patch takes the second approach. It also explicitly adds in the "D"
> flag to make behaviour consistent across different distributions which
> may have different defaults.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>


>
> ---
> V2 Changes: Add in "D" flag for consistency across distros.
> ---
>   mk/rte.lib.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> index 0d7482d..25aa989 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -70,7 +70,7 @@ else
>   _CPU_LDFLAGS := $(CPU_LDFLAGS)
>   endif
>
> -O_TO_A = $(AR) crus $(LIB) $(OBJS-y)
> +O_TO_A = $(AR) crDs $(LIB) $(OBJS-y)
>   O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight
>   O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)","  AR $(@)")
>   O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)"
>