dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Dirk-Holger Lenz <dirk.lenz@ng4t.com>
Cc: dev@dpdk.org
Subject: Re: mk: RTE_BUILD_COMBINE_LIBS doesn't work properly anymore
Date: Wed, 10 Jun 2015 10:42:46 +0100	[thread overview]
Message-ID: <55780696.8010902@intel.com> (raw)
In-Reply-To: <557805AB.5010008@ng4t.com>

On 10/06/2015 10:38, Dirk-Holger Lenz wrote:
> Hello,
> since the hardware specific library functions were put into a separate
> folder 'drivers' the feature to build a combined library doesn't generate
> a combined library including these hardware specific functions anymore.
> The reason for this is that the combined library is built before the
> 'drivers' folder is built.
> For me it worked changing in dpdk/mk/rte.sdkbuild.mk
> line 96 from:
>   @if [ $@ = lib -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \
> to:
>   @if [ $@ = drivers -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \
>
> here the context:
> $(ROOTDIRS-y):
>         @[ -d $(BUILDDIR)/$@ ] || mkdir -p $(BUILDDIR)/$@
>         @echo "== Build $@"
>         $(Q)$(MAKE) S=$@ -f $(RTE_SRCDIR)/$@/Makefile -C 
> $(BUILDDIR)/$@ all
>         @if [ $@ = drivers -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \
>                 $(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \
>         fi
> Best regards
> Dirk
>
Yes, that fixes it.

There is already a patch for it that does exactly that :) (not merge yet 
though).
http://dpdk.org/ml/archives/dev/2015-June/019040.html

Sergio

      reply	other threads:[~2015-06-10  9:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10  9:38 mk: RTE_BUILD_COMBINE_LIBS doesn't work properly anymore Dirk-Holger Lenz
2015-06-10  9:42 ` Gonzalez Monroy, Sergio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55780696.8010902@intel.com \
    --to=sergio.gonzalez.monroy@intel.com \
    --cc=dev@dpdk.org \
    --cc=dirk.lenz@ng4t.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).