From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gonzalez Monroy, Sergio" Subject: Re: mk: RTE_BUILD_COMBINE_LIBS doesn't work properly anymore Date: Wed, 10 Jun 2015 10:42:46 +0100 Message-ID: <55780696.8010902@intel.com> References: <557805AB.5010008@ng4t.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Dirk-Holger Lenz Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9E4565AA0 for ; Wed, 10 Jun 2015 11:42:48 +0200 (CEST) In-Reply-To: <557805AB.5010008@ng4t.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/06/2015 10:38, Dirk-Holger Lenz wrote: > Hello, > since the hardware specific library functions were put into a separate > folder 'drivers' the feature to build a combined library doesn't generate > a combined library including these hardware specific functions anymore. > The reason for this is that the combined library is built before the > 'drivers' folder is built. > For me it worked changing in dpdk/mk/rte.sdkbuild.mk > line 96 from: > @if [ $@ = lib -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \ > to: > @if [ $@ = drivers -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \ > > here the context: > $(ROOTDIRS-y): > @[ -d $(BUILDDIR)/$@ ] || mkdir -p $(BUILDDIR)/$@ > @echo "== Build $@" > $(Q)$(MAKE) S=$@ -f $(RTE_SRCDIR)/$@/Makefile -C > $(BUILDDIR)/$@ all > @if [ $@ = drivers -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \ > $(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \ > fi > Best regards > Dirk > Yes, that fixes it. There is already a patch for it that does exactly that :) (not merge yet though). http://dpdk.org/ml/archives/dev/2015-June/019040.html Sergio