From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] i40e: Remove redundant fdir forward declarations. Date: Fri, 01 Apr 2016 15:42:06 +0200 Message-ID: <5581186.MKO4P7cXSW@xps13> References: <1458955928-11536-1-git-send-email-rami.rosen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, helin.zhang@intel.com To: Rami Rosen Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id A56142BA3 for ; Fri, 1 Apr 2016 15:44:01 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id p65so26690170wmp.1 for ; Fri, 01 Apr 2016 06:44:01 -0700 (PDT) In-Reply-To: <1458955928-11536-1-git-send-email-rami.rosen@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-26 04:32, Rami Rosen: > This patch removes several redundant forward declarations > in i40e_fdir.c. I have the feeling that writing some useless forward declarations is common in some drivers. So why removing only these ones? Are they the only one in i40e?