From mboxrd@z Thu Jan  1 00:00:00 1970
From: Declan Doherty <declan.doherty@intel.com>
Subject: Re: [PATCH 2/2] bonding: fix name and port validation
Date: Fri, 19 Jun 2015 16:52:28 +0100
Message-ID: <55843ABC.6020606@intel.com>
References: <1433973985-17940-1-git-send-email-stephen@networkplumber.org>
 <1433973985-17940-3-git-send-email-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id E00BBC874
 for <dev@dpdk.org>; Fri, 19 Jun 2015 17:46:04 +0200 (CEST)
In-Reply-To: <1433973985-17940-3-git-send-email-stephen@networkplumber.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/06/15 23:06, Stephen Hemminger wrote:
> From: Stephen Hemminger <shemming@brocade.com>
>
> Cleanup the code in bonding that checks ports.
>    * Use standard rte_eth_dev_is_valid_port
>    * Change name of driver string to avoid variable namespace conflicts
>    * Get rid of unnecessary string comparison stuff. A simple pointer
>      check is enough here.
>    * Get rid of unnecessary assignment of driver_name, it is already
>      done by common code.
>    * Don't generate unnecessary log messages on error.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Declan Doherty <declan.doherty@intel.com>