From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 3/7] i40e: ignore the failure of updating
	default filter settings
Date: Fri, 20 Jun 2014 16:16:26 +0200
Message-ID: <5591358.CZJT0GNYNp@xps13>
References: <1403244889-21358-1-git-send-email-helin.zhang@intel.com>
 <1403244889-21358-4-git-send-email-helin.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1403244889-21358-4-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-06-20 14:14, Helin Zhang:
> The failure of updating the default filter setting should be
> ignored. The updating is to change the default vlan filter
> behaviours configured by firmware to expected.
> The failure happens on the firmware version of 4.2.2,
> while doesn't happen on previous versions, as the default
> settings of firmware changed.
[...]
>  		ret = i40e_update_default_filter_setting(vsi);
> -		if (ret != I40E_SUCCESS) {
> -			PMD_DRV_LOG(ERR, "Failed to remove default "
> -						"filter setting\n");
> -			goto fail_msix_alloc;
> -		}
> -	}
> -	else if (type == I40E_VSI_SRIOV) {
> +		if (ret != I40E_SUCCESS)
> +			PMD_DRV_LOG(ERR, "Failure of removing default filter "
> +						"setting can be ignored\n");
> +		/**
> +		 * The failure of updating default filter setting
> +		 * can be ignored
> +		 */
> +	} else if (type == I40E_VSI_SRIOV) {

The log is not clear and the log message doesn't include firmware explanation. 
Please reword.

By the way, there is already a log message in the function:
	PMD_DRV_LOG(WARNING, "Failed to remove default [mac,vlan] config\n");
	http://dpdk.org/browse/dpdk/commit/?id=9d7d8513b587d32b8f66

Will we see these error messages each time we configure an i40e device?
I think it's strange to have a log message saying it can be ignored.
Can it be a real error in some cases?

-- 
Thomas