From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH] fm10k: add missing newline to debug log
Date: Thu, 16 Jul 2015 11:24:49 -0700
Message-ID: <55A7F6F1.4020709@gmail.com>
References: <1437067585-579-1-git-send-email-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>,
 Jing Chen <jing.d.chen@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ig0-f178.google.com (mail-ig0-f178.google.com
 [209.85.213.178]) by dpdk.org (Postfix) with ESMTP id 953BE5A3E
 for <dev@dpdk.org>; Thu, 16 Jul 2015 20:24:51 +0200 (CEST)
Received: by iggf3 with SMTP id f3so20161869igg.1
 for <dev@dpdk.org>; Thu, 16 Jul 2015 11:24:51 -0700 (PDT)
In-Reply-To: <1437067585-579-1-git-send-email-stephen@networkplumber.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 07/16/2015 10:26 AM, Stephen Hemminger wrote:
> If FM10K_DEBUG_DRIVER is enabled, then the log messages about
> function entry are missing newline causing extremely long lines.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
> index 04f8fe9..33d9120 100644
> --- a/drivers/net/fm10k/base/fm10k_osdep.h
> +++ b/drivers/net/fm10k/base/fm10k_osdep.h
> @@ -46,7 +46,7 @@ POSSIBILITY OF SUCH DAMAGE.
>   
>   #define STATIC                  static
>   #define DEBUGFUNC(F)            DEBUGOUT(F);
> -#define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S, ##args)
> +#define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S "\n", ##args)
>   #define DEBUGOUT1(S, args...)   DEBUGOUT(S, ##args)
>   #define DEBUGOUT2(S, args...)   DEBUGOUT(S, ##args)
>   #define DEBUGOUT3(S, args...)   DEBUGOUT(S, ##args)

I think this ends up adding a redundant "\n" to several other DEBUGOUT 
statements then.  Maybe you should update it so that DEBUGFUNC adds the 
"\n" instead of DEBUGOUT.

- Alex