From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH] ethdev: fix ABI breakage in lro code Date: Fri, 17 Jul 2015 01:22:36 +0300 Message-ID: <55A82EAC.5050807@cloudius-systems.com> References: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: John McNamara , dev@dpdk.org Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 603F45A53 for ; Fri, 17 Jul 2015 00:22:39 +0200 (CEST) Received: by wgav7 with SMTP id v7so3492848wga.2 for ; Thu, 16 Jul 2015 15:22:39 -0700 (PDT) In-Reply-To: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/13/15 13:26, John McNamara wrote: > Fix for ABI breakage introduced in LRO addition. Moves > lro bitfield to the end of the struct/member. > > Fixes: 8eecb3295aed (ixgbe: add LRO support) > > Signed-off-by: John McNamara > --- > lib/librte_ether/rte_ethdev.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 79bde89..1c3ace1 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1578,9 +1578,9 @@ struct rte_eth_dev_data { > uint8_t port_id; /**< Device [external] port identifier. */ > uint8_t promiscuous : 1, /**< RX promiscuous mode ON(1) / OFF(0). */ > scattered_rx : 1, /**< RX of scattered packets is ON(1) / OFF(0) */ > - lro : 1, /**< RX LRO is ON(1) / OFF(0) */ > all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */ > - dev_started : 1; /**< Device state: STARTED(1) / STOPPED(0). */ > + dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */ > + lro : 1; /**< RX LRO is ON(1) / OFF(0) */ Acked-by: Vlad Zolotarov > }; > > /**