From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Subject: Re: [PATCH] DPDK fails to build into one single library
 ("CONFIG_RTE_BUILD_COMBINE_LIBS=y").
Date: Tue, 21 Jul 2015 10:53:39 +0100
Message-ID: <55AE16A3.6040701@intel.com>
References: <1437389608-18697-1-git-send-email-alin.rauta@intel.com>
 <1437389608-18697-2-git-send-email-alin.rauta@intel.com>
 <313CE12EB78416478E6F6FC8F09CCF8C353CB9@IRSMSX101.ger.corp.intel.com>
 <1754975.lJ4YckftyJ@xps13>
 <313CE12EB78416478E6F6FC8F09CCF8C354185@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Varlese, Marco" <marco.varlese@intel.com>
To: "Rauta, Alin" <alin.rauta@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 71BF25A0C
 for <dev@dpdk.org>; Tue, 21 Jul 2015 11:53:42 +0200 (CEST)
In-Reply-To: <313CE12EB78416478E6F6FC8F09CCF8C354185@IRSMSX101.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 21/07/2015 10:49, Rauta, Alin wrote:
> The reason why I took into account as a solution the commenting of that line is that LIBRTE_EAL already has rte_malloc integrated.
> So, I'm not sure why the line is needed ...
> /Alin

That line is needed so when we create shared libs it creates a dummy lib 
so we don't brake apps that expect a librte_malloc.so.

I'm working on a fix, will post it soon.

Sergio
>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, July 20, 2015 7:15 PM
> To: Rauta, Alin
> Cc: dev@dpdk.org; Varlese, Marco
> Subject: Re: [dpdk-dev] [PATCH] DPDK fails to build into one single library ("CONFIG_RTE_BUILD_COMBINE_LIBS=y").
>
> 2015-07-20 18:04, Rauta, Alin:
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -33,7 +33,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
>>   
>>   DIRS-y += librte_compat
>>   DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_eal
>> -DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_malloc
> I feel it's not the right fix :)
>
>  From now, I'll test combine lib build.
> Thanks for reporting