From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gonzalez Monroy, Sergio" Subject: Re: [PATCH] malloc: fix combined lib build Date: Tue, 21 Jul 2015 11:20:59 +0100 Message-ID: <55AE1D0B.4010001@intel.com> References: <313CE12EB78416478E6F6FC8F09CCF8C353CAD@IRSMSX101.ger.corp.intel.com> <1437473890-17279-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1437473890-17279-2-git-send-email-sergio.gonzalez.monroy@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: dev@dpdk.org Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5A02C5A5E for ; Tue, 21 Jul 2015 12:21:01 +0200 (CEST) In-Reply-To: <1437473890-17279-2-git-send-email-sergio.gonzalez.monroy@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21/07/2015 11:18, Sergio Gonzalez Monroy wrote: > Malloc was moved to the EAL and dummy malloc library was left > to not brake apps that had a librte_malloc.so dependency. > Note that the dummy library will be removed in the next release. > > When building a combined library, all objects are copied to the same > directory before creating the library itself. > > There a couple of issues: > - CONFIG_RTE_LIBRTE_MALLOC is not a valid option anymore resulting > in wrong syntax and a compilation failure. Fix it by replacing it > with CONFIG_RTE_LIBRTE_EAL. > - As we kept a dummy library, there are now two objects with the > same name. This means that the proper rte_malloc.o object in eal gets > overwritten by an empty rte_malloc.o object from the dummy malloc lib. > Fix it by changing the name of rte_malloc.o object in the dummy > library. > > Fixes: 2f9d47013e4dbb738 ("mem: move librte_malloc to eal/common") > > Reported-by: Alin Rauta > Signed-off-by: Sergio Gonzalez Monroy > --- > I sent the same patch twice by accident, please ignore the second patch. Sergio