From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Subject: Re: [PATCH] eal: fix build
Date: Wed, 29 Jul 2015 16:05:53 +0100
Message-ID: <55B8EBD1.5090104@intel.com>
References: <1438123707-26509-1-git-send-email-helin.zhang@intel.com>
 <4457109.BKbKVosbHQ@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8B6FE3@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Zhang, Helin" <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 2CC80C376
 for <dev@dpdk.org>; Wed, 29 Jul 2015 17:05:56 +0200 (CEST)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8B6FE3@SHSMSX104.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 29/07/2015 16:00, Zhang, Helin wrote:
> Hi Thomas
>
> It was just an implicit declaration of function, when set CONFIG_RTE_PC=
I_CONFIG=3Dy, as follows. Nobody else cares about it.
>
> /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci=
.c: In function =C3=A2=E2=82=AC?rte_eal_pci_probe_one_driver=C3=A2=E2=82=AC=
=E2=84=A2:
> /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci=
.c:188:4: error: implicit declaration of function =C3=A2=E2=82=AC?pci_con=
fig_space_set=C3=A2=E2=82=AC=E2=84=A2 [-Werror=3Dimplicit-function-declar=
ation]
>      pci_config_space_set(dev);
>      ^
> /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci=
.c:188:4: error: nested extern declaration of =C3=A2=E2=82=AC?pci_config_=
space_set=C3=A2=E2=82=AC=E2=84=A2 [-Werror=3Dnested-externs]
> cc1: all warnings being treated as errors
> /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/linuxapp/eal/eal_pci.=
c:561:1: error: =C3=A2=E2=82=AC?pci_config_space_set=C3=A2=E2=82=AC=E2=84=
=A2 defined but not used [-Werror=3Dunused-function]
>   pci_config_space_set(struct rte_pci_device *dev)
>   ^
> cc1: all warnings being treated as errors
>
> Regards,
> Helin
>
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>> Sent: Wednesday, July 29, 2015 1:20 AM
>> To: Zhang, Helin
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] eal: fix build
>>
>> 2015-07-29 06:48, Helin Zhang:
>>> It fixes the build error of implicit declaration of function.
>> What is the error?
>> Please show the build log and describe the case when it happens (compi=
ler,
>> version).
Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux and=20
bsd")

The function rte_eal_pci_probe_one_driver, which calls=20
pci_config_space_set, was moved to eal_common_pci.c,
but pci_config_space_set was left in eal_pci.c with static specifier.

Sergio