From mboxrd@z Thu Jan  1 00:00:00 1970
From: Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [PATCH v4 03/12] vhost: update version map file
Date: Wed, 12 Aug 2015 11:24:23 +0300
Message-ID: <55CB02B7.8040900@redhat.com>
References: <1434355006-30583-1-git-send-email-changchun.ouyang@intel.com>
 <1439366567-3402-1-git-send-email-changchun.ouyang@intel.com>
 <1439366567-3402-4-git-send-email-changchun.ouyang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Ouyang Changchun <changchun.ouyang@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 460038D3A
 for <dev@dpdk.org>; Wed, 12 Aug 2015 10:24:25 +0200 (CEST)
In-Reply-To: <1439366567-3402-4-git-send-email-changchun.ouyang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 08/12/2015 11:02 AM, Ouyang Changchun wrote:
> From: Changchun Ouyang <changchun.ouyang@intel.com>
>
> it is added in v4.
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> ---
>   lib/librte_vhost/rte_vhost_version.map | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> index 3d8709e..0bb1c0f 100644
> --- a/lib/librte_vhost/rte_vhost_version.map
> +++ b/lib/librte_vhost/rte_vhost_version.map
> @@ -18,5 +18,5 @@ DPDK_2.1 {
>   	global:
>
>   	rte_vhost_driver_unregister;
> -
> +	rte_vhost_qp_num_get;
>   } DPDK_2.0;
>

Version map needs to be updated along with the actual code (in this 
case, the function is added in the second patch of the series). 
Otherwise there will be at least one commit where shared library 
configuration will be incorrect and might not be buildable at all.

- Panu -