From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?6LS+5a2m5rab?= Subject: Re: [PATCH] ixgbe: fix LSC callback Date: Tue, 1 Sep 2015 16:09:53 +0800 Message-ID: <55E55D51.10201@sinogrid.com> References: <1441088490-9420-1-git-send-email-jiaxt@sinogrid.com> <6A0DE07E22DDAD4C9103DF62FEBC0909D4282A@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "letaotor@gmail.com" To: "Lu, Wenzhuo" Return-path: Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-pu1apc01on0124.outbound.protection.outlook.com [104.47.126.124]) by dpdk.org (Postfix) with ESMTP id 9A8BF5A58 for ; Tue, 1 Sep 2015 10:10:13 +0200 (CEST) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909D4282A@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Wenzhuo, I bond 82599 ports with mode 802.3ad, the bonding port can't work=20 properly. But bonding with i350 ports works properly. I found the=20 registered callback function bond_ethdev_lsc_event_callback by=20 __eth_bond_slave_add_lock_free was not executed when link status=20 changed. I compared ixgbe driver with igb driver, ixgbe's LSC interrupt=20 action without _rte_eth_dev_callback_process. On 09/01/2015 03:42 PM, Lu, Wenzhuo wrote: > Hi Shelton, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shelton Chia >> Sent: Tuesday, September 1, 2015 2:22 PM >> To: dev@dpdk.org >> Cc: letaotor@gmail.com >> Subject: [dpdk-dev] [PATCH] ixgbe: fix LSC callback >> >> add _rte_eth_dev_callback_process to call callback func > Would you like to give more details about why we need this patch? Thank= s. >> Signed-off-by: Shelton Chia >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgb= e_ethdev.c >> index b8ee1e9..4e4c118 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -2775,6 +2775,8 @@ ixgbe_dev_interrupt_action(struct rte_eth_dev *d= ev) >> >> ixgbe_dev_link_status_print(dev); >> >> + __rte_eth_dev_callback_process(dev, >> RTE_ETH_EVENT_INTR_LSC); >> + >> intr_enable_delay =3D true; >> } >> >> -- >> 2.5.0 --=20 =E8=B4=BE=E5=AD=A6=E6=B6=9B =E4=BF=A1=E8=AF=BA=E7=91=9E=E5=BE=97=E8=A5=BF=E5=AE=89=E7=A0=94=E5=8F=91=E4= =B8=AD=E5=BF=83