From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Hoffmann Subject: Re: [PATCH v1] change hugepage sorting to avoid overlapping memcpy Date: Wed, 9 Sep 2015 10:41:05 +0200 Message-ID: <55EFF0A1.8050000@allegro-packets.com> References: <1441361677-10271-1-git-send-email-ralf.hoffmann@allegro-packets.com> <55EED876.9050307@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: "Gonzalez Monroy, Sergio" Return-path: Received: from smtprelay04.ispgateway.de (smtprelay04.ispgateway.de [80.67.31.27]) by dpdk.org (Postfix) with ESMTP id 9B9BA567F for ; Wed, 9 Sep 2015 10:41:06 +0200 (CEST) In-Reply-To: <55EED876.9050307@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Sergio, On 08.09.2015 14:45, Gonzalez Monroy, Sergio wrote: > Just a few comments/suggestions: >=20 > Add 'eal/linux:' to the commit title, ie: > "eal/linux: change hugepage sorting to avoid overlapping memcpy" >=20 I would modify the patch according to your notes if needed, but if you consider the other patch from Jay, then I would vote for that instead. Actually, I thought about using qsort too, but decided against it to keep the number of changes low and the sorting speed is not a problem for me. Changing the return value of that function to void might still be a good idea. Best Regards, Ralf --=20 Ralf Hoffmann Allegro Packets GmbH K=C3=A4the-Kollwitz-Str. 54 04109 Leipzig HRB 30535, Amtsgericht Leipzig