From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] mem: warn if address hint is not respected
Date: Tue, 7 Nov 2017 13:54:24 +0000
Message-ID: <55afaf0a-14cc-11b0-c7ec-21ea1bc2403f@intel.com>
References: <1509440909-8068-1-git-send-email-jpf@zurich.ibm.com>
 <10656029.OGFJoE0f1c@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Jonas Pfefferle <jpf@zurich.ibm.com>, jianfeng.tan@intel.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 681D61B39C
 for <dev@dpdk.org>; Tue,  7 Nov 2017 14:54:28 +0100 (CET)
In-Reply-To: <10656029.OGFJoE0f1c@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 06-Nov-17 8:26 PM, Thomas Monjalon wrote:
> 31/10/2017 10:08, Jonas Pfefferle:
>> Print a warning if the --base-virtaddr hint is not respected
>> since this might lead to problems when mapping memory in
>> the secondary process.
>>
>> Signed-off-by: Jonas Pfefferle <jpf@zurich.ibm.com>
> 
> Anatoly, please review this patch.
> It does not seem to fix something, so it is candidate for 18.02.
> 

For some reason my Thunderbird ate the original email, so i'll reply to 
this one.

One nitpick would be that we're calling get_virtual_area many times and 
it would probably be a good idea to make pagesize static and call 
sysconf only once. Otherwise,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly