From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH 0/7] Add hierarchical support to make install
Date: Tue, 22 Sep 2015 10:16:43 +0200
Message-ID: <56010E6B.6070703@6wind.com>
References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Mario Carrillo <mario.alfredo.c.arevalo@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id ADF118D94
 for <dev@dpdk.org>; Tue, 22 Sep 2015 10:16:50 +0200 (CEST)
In-Reply-To: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Mario,

On 09/18/2015 10:33 PM, Mario Carrillo wrote:
> DPDK package lacks of a mechanism to install libraries, headers
> applications and kernel modules to a file system tree.
> 
> This patch set allows to install files according to the next
> proposal:
> http://www.freedesktop.org/software/systemd/man/file-hierarchy.html
> 
> By adding a parameter H=1 (hierarchy-file) to makefile system, it is
> possible to do the next steps
> 
> make config T=TARGET
> make
> make install H=1

The current "install" target is not designed to work on one
build directory. Instead, it takes as a parameter a list of
config templates, and the build directory is the name of the
target.

Today, we have:

  make install T="*-native-linuxapp-gcc"

is somehow equivalent to:

  make config T=i686-native-linuxapp-gcc O=i686-native-linuxapp-gcc
  make O=i686-native-linuxapp-gcc
  make config T=x86_32-native-linuxapp-gcc O=x86_32-native-linuxapp-gcc
  make O=x86_32-native-linuxapp-gcc
  make config T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc
  make O=x86_64-native-linuxapp-gcc

The "install H=1" directive you are adding seems to implicitly be
working on a build directory (modifiable with O=), which is the case
for the "make" command but not for the current "make install".

I'm in favor of having different command names for installing
a binary sdk and for installing the runtime libs in the hierarchical
file system, this to avoid having different behaviors for the same
name.

Regards,
Olivier