From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCHv4 3/9] null: extend number of virtual queues
Date: Tue, 29 Sep 2015 11:24:39 +0900
Message-ID: <5609F667.2010800@igel.co.jp>
References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-4-git-send-email-tomaszx.kulasek@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com
 [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 7131758EF
 for <dev@dpdk.org>; Tue, 29 Sep 2015 04:24:41 +0200 (CEST)
Received: by pacex6 with SMTP id ex6so191025941pac.0
 for <dev@dpdk.org>; Mon, 28 Sep 2015 19:24:40 -0700 (PDT)
In-Reply-To: <1436981189-3320-4-git-send-email-tomaszx.kulasek@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/07/16 2:26, Tomasz Kulasek wrote:
> This patch adds a possibility to configure more than one queue on null
> device.
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
>  drivers/net/null/rte_eth_null.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index a8b3191..39ffcde 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -71,8 +71,8 @@ struct pmd_internals {
>  	unsigned nb_rx_queues;
>  	unsigned nb_tx_queues;
>  
> -	struct null_queue rx_null_queues[1];
> -	struct null_queue tx_null_queues[1];
> +	struct null_queue rx_null_queues[RTE_MAX_QUEUES_PER_PORT];
> +	struct null_queue tx_null_queues[RTE_MAX_QUEUES_PER_PORT];
>  };
>  
>  
> @@ -213,7 +213,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
>  	if ((dev == NULL) || (mb_pool == NULL))
>  		return -EINVAL;
>  
> -	if (rx_queue_id != 0)
> +	if (rx_queue_id >= dev->data->nb_rx_queues)
>  		return -ENODEV;
>  
>  	internals = dev->data->dev_private;
> @@ -246,7 +246,7 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
>  	if (dev == NULL)
>  		return -EINVAL;
>  
> -	if (tx_queue_id != 0)
> +	if (tx_queue_id >= dev->data->nb_tx_queues)
>  		return -ENODEV;
>  
>  	internals = dev->data->dev_private;
> @@ -279,8 +279,8 @@ eth_dev_info(struct rte_eth_dev *dev,
>  	dev_info->driver_name = drivername;
>  	dev_info->max_mac_addrs = 1;
>  	dev_info->max_rx_pktlen = (uint32_t)-1;
> -	dev_info->max_rx_queues = (uint16_t)internals->nb_rx_queues;
> -	dev_info->max_tx_queues = (uint16_t)internals->nb_tx_queues;
> +	dev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues);
> +	dev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues);
>  	dev_info->min_rx_bufsize = 0;
>  	dev_info->pci_dev = NULL;
>  }

Hi Thomasz,

To do like above, should we change below variables also?

static int
eth_dev_null_create(const char *name,
                const unsigned numa_node,
                unsigned packet_size,
                unsigned packet_copy)
{
        const unsigned nb_rx_queues = 1;
        const unsigned nb_tx_queues = 1;

        (snip)

}

Tetsuya