From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v2] Change rte_eal_vdev_init to update port_id
Date: Tue, 29 Sep 2015 12:32:19 +0900
Message-ID: <560A0643.7050800@igel.co.jp>
References: <1440013341-29659-1-git-send-email-rkerur@gmail.com>
 <1440013376-29715-1-git-send-email-rkerur@gmail.com>
 <55D53655.1040808@igel.co.jp>
 <CAFb4SLBpa8LF2K6-tjK+bk20tKsoJLd2nwDqdmySJg=A9402Eg@mail.gmail.com>
 <55D69C00.2020609@igel.co.jp>
 <CAFb4SLCuS70jtY+bsNM9e0=YoeBC614BD8XNyNhVeJPofAJ4aQ@mail.gmail.com>
 <CALwxeUtHL+bzd92XeUcgeO4w6=J7XRPLb1NO3+2=vWY5-MiwMA@mail.gmail.com>
 <CAFb4SLBZV3N8_SVB3Nra+3v4Np0at4DN52wYwiHBe9PEGzG5LA@mail.gmail.com>
 <CAFb4SLCHP8+b_GU0Y6Y_etxxOyzHGD9dV_9Rh01E24U6ZsT1nw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Ravi Kerur <rkerur@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com
 [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id AB8F212A8
 for <dev@dpdk.org>; Tue, 29 Sep 2015 05:32:21 +0200 (CEST)
Received: by pablk4 with SMTP id lk4so95706253pab.3
 for <dev@dpdk.org>; Mon, 28 Sep 2015 20:32:21 -0700 (PDT)
In-Reply-To: <CAFb4SLCHP8+b_GU0Y6Y_etxxOyzHGD9dV_9Rh01E24U6ZsT1nw@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/09/24 6:22, Ravi Kerur wrote:
> Hi David, Tetsuya,
>
> I have sent V3 (changes isolated to rte_ether component) for formal review.
> Please look into it and let me know your inputs.

Hi Ravi,

I've checked the patch.
I guess your patch is good.

>
> @David: I looked at "rte_eth_dev_get_port_by_name()", this function is
> similar to "rte_eth_dev_get_name_by_port" and I have used same logic. Let
> me know if this not correct I can fix both.

Do you comment about rte_eth_dev_get_port_by_name and
rte_eth_dev_get_port_by_addr?
If so, I guess we don't need to merge.

> Thanks,
> Ravi
>
>
> On Tue, Sep 15, 2015 at 4:28 AM, Ravi Kerur <rkerur@gmail.com> wrote:
>
>> Hi David,
>>
>>
>> On Thu, Sep 3, 2015 at 7:04 AM, David Marchand <david.marchand@6wind.com>
>> wrote:
>>
>>> Hello Ravi, Tetsuya,
>>>
>>> On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur <rkerur@gmail.com> wrote:
>>>
>>>> Let us know how you want us to fix this? To fix rte_eal_vdev_init and
>>>> rte_eal_pci_probe_one to return allocated port_id we had 2 approaches
>>>> mentioned in earlier discussion. In addition to those we have another
>>>> approach with changes isolated only to rte_ether component. I am attaching
>>>> diffs (preliminary) with this email. Please let us know your inputs since
>>>> it involves EAL component.
>>>>
>>> - This patch looks like a good ethdev cleanup (even if it really lacks
>>> some context / commit log).
>>>
>>> I wonder just why you only take the first part of the name in
>>> rte_eth_dev_get_port_by_name().
>>> Would not this match, let's say, both toto and toto0 vdevs ?
>>> Is this intended ?
>>>
>>> It was not intended, i will look into it.
>>> - In the end, with this patch, do we still need to update eal ?
>>> Looking at the code, I am not sure anymore.
>>>
>> Approach 3 (preliminary diffs sent as an attachment) doesn't involve EAL
>> but the other two solutions do. So please let us know which one you prefer.
>> I will send updated patch.
>>
>> Thanks,
>> Ravi
>>
>>
>>>
>>>
>>> --
>>> David Marchand
>>>
>>