From mboxrd@z Thu Jan  1 00:00:00 1970
From: Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [PATCH v2 1/8] mk: Add rule for installing headers
Date: Tue, 29 Sep 2015 11:49:18 +0300
Message-ID: <560A508E.5000404@redhat.com>
References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com>
 <1443484863-18652-1-git-send-email-mario.alfredo.c.arevalo@intel.com>
 <1443484863-18652-2-git-send-email-mario.alfredo.c.arevalo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Mario Carrillo <mario.alfredo.c.arevalo@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 82DC93787
 for <dev@dpdk.org>; Tue, 29 Sep 2015 10:49:20 +0200 (CEST)
In-Reply-To: <1443484863-18652-2-git-send-email-mario.alfredo.c.arevalo@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/29/2015 03:00 AM, Mario Carrillo wrote:
> Add hierarchy-file support to the DPDK headers,
> when invoking "make install-headers" headers will
> be installed in: $(DESTDIR)/usr/include/dpdk
> This hierarchy is based on:
> http://www.freedesktop.org/software/systemd/man/file-hierarchy.html
>
> Signed-off-by: Mario Carrillo <mario.alfredo.c.arevalo@intel.com>
> ---
>   mk/rte.sdkinstall.mk | 17 +++++++++++++++++
>   mk/rte.sdkroot.mk    |  4 ++--
>   2 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
> index 86c98a5..3ec344e 100644
> --- a/mk/rte.sdkinstall.mk
> +++ b/mk/rte.sdkinstall.mk
> @@ -40,7 +40,12 @@ endif
>   # target name or a name containing jokers "*". Example:
>   # x86_64-native-*-gcc
>   ifndef T
> +ifeq (,$(wildcard $(BUILD_DIR)/build/.config))
>   T=*
> +else
> +INCLUDE_DIR := $(DESTDIR)/usr/include/dpdk

This makes it cumbersome to override INCLUDE_DIR. Please keep $(DESTDIR) 
separate and only use it when actually copying, and only set INCLUDE_DIR 
here if not already set, ie

INCLUDE_DIR ?= /usr/include/dpdk

...and then something like:
     @[ -d $(DESTDIR)/$(INCLUDE_DIR) ] || mkdir -p $(DESTDIR)/$(INCLUDE_DIR)
     @for HSLINK in ${HSLINKS}; do \
     HEADER=$$(readlink -f $$HSLINK); \
     cp -rf $$HEADER ${DESTDIR}/${INCLUDE_DIR}; \
     echo installing: $$HEADER; \

The same goes for all the locations in the other patches.

The need to override includedir might not be that common, but for 
example it could be used for installing multiple versions in parallel. 
For others like LIB_DIR the ability to override is truly required 
because distros differ wildly in this regard.

Thanks for working on this!

	- Panu -