From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [PATCH 0/2] uio_msi: device driver Date: Thu, 1 Oct 2015 12:48:36 -0700 Message-ID: <560D8E14.5030500@gmail.com> References: <1443652138-31782-1-git-send-email-stephen@networkplumber.org> <560D11F6.2080609@scylladb.com> <20151001075731.2f079237@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, hjk@hansjkoch.de, gregkh@linux-foundation.org, linux-kernel@vger.kernel.org To: Stephen Hemminger , Avi Kivity Return-path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 4F4FD8E64 for ; Thu, 1 Oct 2015 21:48:39 +0200 (CEST) Received: by padhy16 with SMTP id hy16so83511536pad.1 for ; Thu, 01 Oct 2015 12:48:38 -0700 (PDT) In-Reply-To: <20151001075731.2f079237@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/01/2015 07:57 AM, Stephen Hemminger wrote: > On Thu, 1 Oct 2015 13:59:02 +0300 > Avi Kivity wrote: > >> On 10/01/2015 01:28 AM, Stephen Hemminger wrote: >>> This is a new UIO device driver to allow supporting MSI-X and MSI devices >>> in userspace. It has been used in environments like VMware and older versions >>> of QEMU/KVM where no IOMMU support is available. >> Why not add msi/msix support to uio_pci_generic? > That is possible but that would meet ABI and other resistance from the author. > Also, uio_pci_generic makes it harder to find resources since it doesn't fully > utilize UIO infrastructure. I'd say you are better off actually taking this in the other direction. >>From what I have seen it seems like this driver is meant to deal with mapping VFs contained inside of guests. If you are going to fork off and create a UIO driver for mapping VFs why not just make it specialize in that. You could probably simplify the code by dropping support for legacy interrupts and IO regions since all that is already covered by uio_pci_generic anyway if I am not mistaken. You could then look at naming it something like uio_vf since the uio_msi is a bit of a misnomer since it is MSI-X it supports, not MSI interrupts. - Alex