From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH v5 4/4] testpmd: make use of per-PMD TxRx
 parameters
Date: Mon, 9 Apr 2018 15:38:30 +0100
Message-ID: <560b67af-3650-7be6-d4d6-b0de6bf00c0c@intel.com>
References: <20180406145002.27480-1-remy.horton@intel.com>
 <20180406145002.27480-5-remy.horton@intel.com>
 <ea929c43-d344-49d4-8c3b-229af6f30ce4@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: John McNamara <john.mcnamara@intel.com>, Wenzhuo Lu
 <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 398E51B817
 for <dev@dpdk.org>; Mon,  9 Apr 2018 16:38:34 +0200 (CEST)
In-Reply-To: <ea929c43-d344-49d4-8c3b-229af6f30ce4@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 09/04/2018 13:55, Shreyansh Jain wrote:
[..]
> Documentation for burst mode changes to testpmd would need an update.
> I guess, only when the user explicitly sets 'set burst 0' would the
> driver defaults be picked up - isn't it?

Yes.


> Maybe something like this:
>
> --->8---
> --- a/doc/guides/testpmd_app_ug/run_app.rst
> +++ b/doc/guides/testpmd_app_ug/run_app.rst
> @@ -372,7 +372,9 @@ The commandline options are:
>  *   ``--burst=N``
>
>      Set the number of packets per burst to N, where 1 <= N <= 512.
> -    The default value is 16.
> +    The default value is 32.
> +    If set to 0, driver default is used if defined. Else, if driver
> default
> +    is not defined, default of 32 is used.
>
>  *   ``--mbcache=N``
> --->8---
>
> In the above, I think the existing documented default value needs to be
> changed. It is set to '#define DEF_PKT_BURST 32'

Had a quick look and it looks like that discrepancy has been there since 
the documentation was converted to .rst in 2014.


> If you add that, please use my ack for next revision.
> (For patch 1/4, I had already given my Ack in v2)

I'll add in the snippet above. 18.05 integration deadline has I think 
passed, but documentation changes will still get in.