From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH 1/5] eal: refactor plugin list append from eal_parse_args() to a helper function Date: Fri, 16 Oct 2015 16:07:46 +0300 Message-ID: <5620F6A2.1020408@redhat.com> References: <20151016125727.GB9980@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 53D2D8E56 for ; Fri, 16 Oct 2015 15:07:49 +0200 (CEST) In-Reply-To: <20151016125727.GB9980@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/16/2015 03:57 PM, Bruce Richardson wrote: > On Fri, Oct 16, 2015 at 02:58:13PM +0300, Panu Matilainen wrote: >> Signed-off-by: Panu Matilainen >> --- >> lib/librte_eal/linuxapp/eal/eal.c | 28 +++++++++++++++++++--------- >> 1 file changed, 19 insertions(+), 9 deletions(-) >> >> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c >> index 33e1067..cc66d9f 100644 >> --- a/lib/librte_eal/linuxapp/eal/eal.c >> +++ b/lib/librte_eal/linuxapp/eal/eal.c >> @@ -530,6 +530,24 @@ eal_log_level_parse(int argc, char **argv) >> optind = 0; /* reset getopt lib */ >> } >> >> +static int >> +eal_plugin_add(const char *path) >> +{ >> + struct shared_driver *solib; >> + >> + solib = malloc(sizeof(*solib)); >> + if (solib == NULL) { >> + RTE_LOG(ERR, EAL, "malloc(solib) failed\n"); >> + return -1; >> + } >> + memset(solib, 0, sizeof(*solib)); >> + strncpy(solib->name, path, PATH_MAX-1); >> + solib->name[PATH_MAX-1] = 0; > > I always prefer a one-line snprintf to the above two-line code. :-) Me too (or asprintf, depending on situation), but the point of this patch is to move around existing code without changing it. Certainly I can change it to sprintf if that's preferred. - Panu -