From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH v2 2/3] l2fwd: keep alive sample application
Date: Tue, 27 Oct 2015 08:48:41 +0000
Message-ID: <562F3A69.1040306@intel.com>
References: <1443603881-4700-1-git-send-email-remy.horton@intel.com>
 <1443603881-4700-3-git-send-email-remy.horton@intel.com>
 <1A27633A6DA49C4A92FCD5D4312DBF536A5D9327@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: "Tahhan, Maryam" <maryam.tahhan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D6A36374E
 for <dev@dpdk.org>; Tue, 27 Oct 2015 09:48:53 +0100 (CET)
In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536A5D9327@IRSMSX109.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 23/10/2015 15:23, Tahhan, Maryam wrote:

>>   # binary name
>> -APP = l2fwd
>> +APP = l2fwd-keepalive
> Hi Remy,
> Looks great overall, just a couple of comments
> For backward compatibility the rename could be a nightmare? What do you think?

True. Undecided whether to change the Makefile(s) so that both keepalive 
and non-keepalive l2fwd are built, or to simply clone all of l2fwd..


>> +		 * Die randomly within 7 secs for demo purposes if
>> +		 * keepalive enables
>> +		 */
>
> Typo: If keepalive is enabled

Fixed.. :)