From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v2 3/6] eal/arm: add 64-bit armv8 version of
	rte_cycles.h
Date: Fri, 30 Oct 2015 13:18:17 +0000
Message-ID: <56336E19.2020004@intel.com>
References: <1446205886-23823-1-git-send-email-david.hunt@intel.com>
 <1446205886-23823-4-git-send-email-david.hunt@intel.com>
 <20151030134456.4bedfb2e@pcviktorin.fit.vutbr.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Jan Viktorin <viktorin@rehivetech.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 9C4768E7B
 for <dev@dpdk.org>; Fri, 30 Oct 2015 14:18:38 +0100 (CET)
In-Reply-To: <20151030134456.4bedfb2e@pcviktorin.fit.vutbr.cz>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 30/10/2015 12:44, Jan Viktorin wrote:
> On Fri, 30 Oct 2015 11:51:23 +0000
> David Hunt <david.hunt@intel.com> wrote:
>
>> +static inline uint64_t
>> +rte_rdtsc(void)
>> +{
>> +	uint64_t tsc;
>> +
>> +	asm volatile("mrs %0, CNTVCT_EL0" : "=r" (tsc));
>> +
>> +#ifdef RTE_TIMER_MULTIPLIER
>> +	return tsc * RTE_TIMER_MULTIPLIER;
>> +#else
>
> I think, this should be CONFIG_RTE_TIMER_MULTIPLIER.
>
> Jan

Jan,
     Thanks for the super-fast review :)

     I've taken a look at this and RTE_TIMER_MULTIPLIER is present in 
the generated include/rte_config.h, so it compiles and run fine. I've 
also confirmed this by removing the #ifdef, forcing the use of 
RTE_TIMER_MULTIPLIER as a test.
Dave.