From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v3 6/6] test: add checks for cpu flags on
	armv8
Date: Mon, 2 Nov 2015 15:04:14 +0000
Message-ID: <56377B6E.70502@intel.com>
References: <1446212826-19425-7-git-send-email-david.hunt@intel.com>
 <5633798B.2050708@intel.com>
 <20151030161106.4657232.16920.465@rehivetech.com>
 <56339AA9.1060505@intel.com> <20151102063209.GC17659@localhost.localdomain>
 <56373F59.6080602@intel.com> <20151102131710.GA10385@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id CF12C5A32
 for <dev@dpdk.org>; Mon,  2 Nov 2015 16:04:16 +0100 (CET)
In-Reply-To: <20151102131710.GA10385@localhost.localdomain>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 02/11/2015 13:17, Jerin Jacob wrote:
-snip--
> If am not wrong existing  rte_cpu_get_flag_enabled() implementation
> should be broken in your platform also for arm64. as I could see only AT_HWCAP
> not AT_HWCAP2 and AT_HWCAP is 0x7 that means your platform also
> follows
>
> http://lxr.free-electrons.com/source/arch/arm64/include/uapi/asm/hwcap.h
>
> and the implmentation is
>
> FEAT_DEF(SWP,       0x00000001, 0, REG_HWCAP,  0) // not correct for arm64
> FEAT_DEF(HALF,      0x00000001, 0, REG_HWCAP,  1) // not correct for arm64
> FEAT_DEF(THUMB,     0x00000001, 0, REG_HWCAP,  2) // not correct for arm64
> FEAT_DEF(A26BIT,    0x00000001, 0, REG_HWCAP,  3)
--snip--
> FEAT_DEF(CRC32,     0x00000001, 0, REG_HWCAP2,  4)
> FEAT_DEF(AARCH32,   0x00000001, 0, REG_PLATFORM, 0)
> FEAT_DEF(AARCH64,   0x00000001, 0, REG_PLATFORM, 1)
>
> Am I missing something ?

You are correct. I need to re-visit this. In merging the ARMv7 and 
ARVv8, I should have split the hardware capabilities flags into 32-but 
and 64-bit versions. I'll do that in the next patch.
Thanks,
Dave.