From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcel Apfelbaum <marcel@redhat.com>
Subject: Re: [PATCH] vhost-user: enable virtio 1.0
Date: Tue, 3 Nov 2015 10:30:48 +0200
Message-ID: <563870B8.6090401@redhat.com>
References: <1444907319-26348-1-git-send-email-marcel@redhat.com>
 <56386A34.2000004@redhat.com>
 <C37D651A908B024F974696C65296B57B4B168145@SHSMSX101.ccr.corp.intel.com>
 <2031631.BKEczujSzy@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, "Michael S. Tsirkin" <mst@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 "Xie, Huawei" <huawei.xie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id D94358E6E
 for <dev@dpdk.org>; Tue,  3 Nov 2015 09:30:52 +0100 (CET)
In-Reply-To: <2031631.BKEczujSzy@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/03/2015 10:26 AM, Thomas Monjalon wrote:
> 2015-11-03 08:16, Xie, Huawei:
>> On 11/3/2015 4:03 PM, Marcel Apfelbaum wrote:
>>> On 11/03/2015 05:49 AM, Xu, Qian Q wrote:
>>>> Sorry, correct the kernel info, my kernel version is
>>>> 4.1.8-100.fc21.x86_64.
>>>
>>> Hi,
>>>
>>> This is weird, VIRTIO_F_VERSION_1 is defined in 4.0 (I think), and for
>>> sure in 4.1 .
>>> You can see commit 4ec22fae (virtio: add virtio 1.0 feature bit) from
>>> 2014-10-22 in kernel git.
>>>
>>> Can you please check a mismatch in header files of your development
>>> machine?
>> Marcel:
>> Would you prepare the ifdef fix? We have done the same thing in vhost
>> multiple queue patch.
>
> Everybody (including me) forgot the support of older kernel.
> Please provide a fix ASAP.
>

Sure, I'll send a fix today. (on top of my prev patch)

Thanks,
Marcel