From mboxrd@z Thu Jan  1 00:00:00 1970
From: Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [PATCH v2] mk: fix ABI versioning compile error for
 combined shared library
Date: Tue, 3 Nov 2015 12:41:10 +0200
Message-ID: <56388F46.7040405@redhat.com>
References: <20151102102023.GA29052@sivlogin002.ir.intel.com>
 <1446477827-11541-1-git-send-email-ferruh.yigit@intel.com>
 <56385CDD.2030909@redhat.com>
 <20151103092033.GA16414@sivlogin002.ir.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: dev@dpdk.org, Eric Kinzie <ekinzie@brocade.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id D4C188E7E
 for <dev@dpdk.org>; Tue,  3 Nov 2015 11:41:12 +0100 (CET)
In-Reply-To: <20151103092033.GA16414@sivlogin002.ir.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/03/2015 11:20 AM, Ferruh Yigit wrote:
> On Tue, Nov 03, 2015 at 09:06:05AM +0200, Panu Matilainen wrote:
>> On 11/02/2015 05:23 PM, Ferruh Yigit wrote:
>>> Fixes following error:
>>>     LD libdpdk.so
>>>     /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found
>>>     for symbol <function>@DPDK_x.y
>>>
>>> Defines version symbols in a fixed path libdpdk.map file and this
>>> value hardcoded into makefile
>>
>> Hold on. What problem is this supposed to be fixing?
> This patch is to fix combined library compilation error when ABI versining used.
> Currently if ABI version macros used (VERSION_SYMBOL), we are not able to compile combined shared library.
>
>> If its for the bonding thing (as it'd appear from the threading), NAK.
> Nothing directly related to the bonding, just issue observed in this thread.

Okay, understood, it was just not clear from the description. Since 
there are no users of VERSION_SYMBOL etc macros this error has not come 
up until now.

>
>> The symbol versioning in
>> that patch is confused needs to be fixed there instead of inventing strange
>> workarounds elsewhere.
>>
> This is not intented to be a workaround but a fix, unless you have a better idea.

The problem is, it undoes the other benefit of symbol versioning: hiding 
the internal symbols. So in my eyes its more of a hack or a workaround 
than a fix.

I'd much much rather see this as a solution:
http://dpdk.org/dev/patchwork/patch/4262/

	- Panu -


>
>