From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liang, Cunming" Subject: Re: [PATCH v2 05/11] eal/linux: add intr api to report multi-vector capability Date: Wed, 4 Nov 2015 09:21:27 +0800 Message-ID: <56395D97.3030808@intel.com> References: <1443072831-19065-1-git-send-email-cunming.liang@intel.com> <1446182873-28814-1-git-send-email-cunming.liang@intel.com> <1446182873-28814-6-git-send-email-cunming.liang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: David Marchand Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 06B5C8E95 for ; Wed, 4 Nov 2015 02:21:30 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, On 11/2/2015 11:59 PM, David Marchand wrote: > On Fri, Oct 30, 2015 at 6:27 AM, Cunming Liang > wrote: > >> VFIO allows multiple MSI-X vector, others doesn't, but maybe will allow it >> in the future. >> Device drivers need to be aware of the capability. >> It's better to avoid condition check on interrupt type(VFIO) everywhere, >> instead >> a capability api is more flexible for the condition change. >> >> Signed-off-by: Cunming Liang >> --- >> lib/librte_eal/linuxapp/eal/eal_interrupts.c | 9 >> +++++++++ >> lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h | 10 >> ++++++++++ >> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +++++++ >> 3 files changed, 26 insertions(+) >> >> > BSD has wrappers for the rest of this api, please add one for this too. Yes, you're right. Thanks. >