From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Simon_K=c3=a5gstr=c3=b6m?= <simon.kagstrom@netinsight.net>
Subject: Re: [PATCH] rte_ether: clarify
 rte_eth_set_queue_rate_limit tx_rate parameter
Date: Wed, 4 Nov 2015 08:51:03 +0100
Message-ID: <5639B8E7.3070702@netinsight.net>
References: <20151020152055.1600b6d5@miho>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: thomas.monjalon@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21])
 by dpdk.org (Postfix) with SMTP id 0B1FD8E7B
 for <dev@dpdk.org>; Wed,  4 Nov 2015 08:51:11 +0100 (CET)
In-Reply-To: <20151020152055.1600b6d5@miho>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Ping?

// Simon

On 2015-10-20 15:20, Simon Kagstrom wrote:
> The tx_rate unit is Mbps.
> 
> Gleaned from the ixgbe implementation, the 82599 datasheet and the use
> in test-pmd.
> 
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> ---
>  lib/librte_ether/rte_ethdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 8a8c82b..ff9aab7 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -3021,7 +3021,7 @@ int rte_eth_mirror_rule_reset(uint8_t port_id,
>   * @param queue_idx
>   *   The queue id.
>   * @param tx_rate
> - *   The tx rate allocated from the total link speed for this queue.
> + *   The tx rate in Mbps. Allocated from the total port link speed.
>   * @return
>   *   - (0) if successful.
>   *   - (-ENOTSUP) if hardware doesn't support this feature.
>