From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: Re: [PATCH v6 07/10] qat_crypto_pmd: Addition of a new QAT DPDK PMD. Date: Fri, 13 Nov 2015 16:25:35 +0000 Message-ID: <56460EFF.8040806@intel.com> References: <1447101259-18972-1-git-send-email-declan.doherty@intel.com> <1447176763-19303-1-git-send-email-declan.doherty@intel.com> <1447176763-19303-8-git-send-email-declan.doherty@intel.com> <1834242.iLgMQtWqy4@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3D84895C0 for ; Fri, 13 Nov 2015 17:26:47 +0100 (CET) In-Reply-To: <1834242.iLgMQtWqy4@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/11/15 16:00, Thomas Monjalon wrote: > 2015-11-10 17:32, Declan Doherty: >> --- a/lib/librte_mbuf_offload/rte_mbuf_offload.h >> +++ b/lib/librte_mbuf_offload/rte_mbuf_offload.h >> @@ -123,17 +123,10 @@ rte_pktmbuf_offload_get(struct rte_mbuf *m, enum rte_mbuf_ol_op_type type) >> { >> struct rte_mbuf_offload *ol = m->offload_ops; >> >> - if (m->offload_ops != NULL && m->offload_ops->type == type) >> - return ol; >> - >> - ol = m->offload_ops; >> - while (ol != NULL) { >> + for (ol = m->offload_ops; ol != NULL; ol = ol->next) >> if (ol->type == type) >> return ol; >> >> - ol = ol->next; >> - } >> - >> return ol; >> } > > Strange: why changing the code of the previous patch? > I squashed this tidy up into the wrong patch. I'll fix in v7