From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2]xen:reserve memory at installing dom0_mm kernel module Date: Fri, 23 May 2014 10:19:59 +0200 Message-ID: <5649427.rlZUqcKHhV@xps13> References: <1400827990-14324-1-git-send-email-jijiang.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Jijiang Liu Return-path: In-Reply-To: <1400827990-14324-1-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Jijiang, 2014-05-23 14:53, Jijiang Liu: > The patch changes the way of reserving memory in Dom0 driver. It will > reserve memory at installing rte_dom0_mm.ko kernel module instead of > requesting memory dynamically during DPDK application startup. Meanwhile, > now driver requests memory size of 4M once first, if it failed, and request > memory size of 2M once. The main reasons we do these changes as follows: > > First, to reduce the impact of inceasing in memory fragment after system run > a long time. Second, to reduce number of memory segment > > Signed-off-by: Jijiang Liu > --- Thanks for sending new version of this patch. Just a note for next time, as explained in this page: http://dpdk.org/dev#send it's a good practice do put a changelog after the 3 dashes. It allows to us to understand why this new version is for. In this case, the changelog should be: changes in v2: - fix code style according to checkpatch.pl Thanks -- Thomas