From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roger B. Melton" Subject: Re: Making rte_eal_pci_probe() in rte_eal_init() optional? Date: Tue, 17 Nov 2015 08:56:37 -0500 Message-ID: <564B3215.9020103@cisco.com> References: <56475966.2080404@cisco.com> <56489A95.1050706@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Don Provan To: David Marchand Return-path: Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) by dpdk.org (Postfix) with ESMTP id B319F5A6C for ; Tue, 17 Nov 2015 14:56:40 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, in-line -Roger On 11/16/15 4:46 AM, David Marchand wrote: > Hello Roger, > > On Sun, Nov 15, 2015 at 3:45 PM, Roger B. Melton > wrote: > > I like the "-b all" and "-w none" idea, but I think it might be > complicated to implement it the way we would need it to work. The > existing -b and -w options persist for the duration of the > application, and we would need the "-b all"/"-w none" to persists > only through rte_eal_init() time. Otherwise our attempt to to > attach a device at a later time would be blocked by the option. > > > I agree, the black/white lists should only apply to initial scan. > I forgot about this problem ... > I had started some cleanup in the pci scan / attach code but this is > too late for 2.2, I will post this in the next merge window. > > > Wouldn't it be simpler to have an option to disable the > rte_eal_init() time the probe. Would that address the issue with > VFIO, prevent automatically attaching to devices while permitting > on demand attach? > > > I suppose we can do this yes (I think Thomas once proposed off-list an > option like --no-pci-scan). > Do you think you can send a patch ? What about --no-pci-init-probe? I know it's long, but it is more descriptive of it's purpose to disable only the init time pci probe. I code and test and have it ready. I'm still working through internal processes to allow me to submit patches, but I hope to have that resolved in the next few weeks and at that time I can submit the patch. > > > -- > David Marchand >