From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH v4 1/3] rte: add keep alive functionality
Date: Wed, 18 Nov 2015 10:21:09 +0000
Message-ID: <564C5115.4070703@intel.com>
References: <1446723178-14876-1-git-send-email-remy.horton@intel.com>	<1446723178-14876-2-git-send-email-remy.horton@intel.com>
 <20151111082801.3eedaf21@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id A92DC5A53
 for <dev@dpdk.org>; Wed, 18 Nov 2015 11:21:18 +0100 (CET)
In-Reply-To: <20151111082801.3eedaf21@xeon-e3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 11/11/2015 16:28, Stephen Hemminger wrote:
> Also Linux has more robust mechanism in the watchdog timers, why not use that?

Keepalive was made with tight intra-process reporting intervals of 
5-10ms in mind, whereas Linux watchdog appears to be an inter-process 
system that operates with granularity of seconds.


> Could you use RTE_PER_LCORE some how?

Possibly, although not sure what it gains..


>> +	struct rte_keepalive *keepcfg = (struct rte_keepalive *)ptr_data;
> Cast of void  * is unnecessary in C.

Old habbits die hard.. :)

v+1 on way.


..Remy