From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve() Date: Wed, 18 Nov 2015 14:16:49 +0200 Message-ID: <564C6C31.9090605@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: "Mcnamara, John" , "dev@dpdk.org" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 52A9D5A68 for ; Wed, 18 Nov 2015 13:16:52 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/18/2015 01:48 PM, Mcnamara, John wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen >> Sent: Wednesday, November 18, 2015 7:34 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for >> rte_eth_dma_zone_reserve() >> >> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime") >> >> Signed-off-by: Panu Matilainen > > Acked-by: John McNamara > > Out of curiosity, how did you identify this issue? These kind of issues are hard not to notice when using shared library configuration once there's something actually using the symbol. In this case, the four commits following 719dbebceb81 make the e1000, ixgbe, i40 and fm10k pmds unloadable respectively: librte_pmd_ixgbe.so: undefined symbol: rte_eth_dma_zone_reserve Driver autoloading does help unearthing these issues too since all the pmd's get loaded regardless of the actual hardware present. - Panu -