* [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve()
@ 2015-11-18 7:33 Panu Matilainen
2015-11-18 11:48 ` Mcnamara, John
0 siblings, 1 reply; 4+ messages in thread
From: Panu Matilainen @ 2015-11-18 7:33 UTC (permalink / raw)
To: dev
Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
lib/librte_ether/rte_ether_version.map | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
index 11c4e94..0c35d53 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -133,6 +133,7 @@ DPDK_2.2 {
rte_eth_copy_pci_info;
rte_eth_dev_get_dcb_info;
+ rte_eth_dma_zone_reserve;
rte_eth_rx_queue_info_get;
rte_eth_timesync_adjust_time;
rte_eth_timesync_read_time;
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve()
2015-11-18 7:33 [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve() Panu Matilainen
@ 2015-11-18 11:48 ` Mcnamara, John
2015-11-18 12:16 ` Panu Matilainen
2015-11-23 21:22 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Mcnamara, John @ 2015-11-18 11:48 UTC (permalink / raw)
To: Panu Matilainen, dev@dpdk.org
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
> Sent: Wednesday, November 18, 2015 7:34 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
> rte_eth_dma_zone_reserve()
>
> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Out of curiosity, how did you identify this issue?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve()
2015-11-18 11:48 ` Mcnamara, John
@ 2015-11-18 12:16 ` Panu Matilainen
2015-11-23 21:22 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Panu Matilainen @ 2015-11-18 12:16 UTC (permalink / raw)
To: Mcnamara, John, dev@dpdk.org
On 11/18/2015 01:48 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
>> Sent: Wednesday, November 18, 2015 7:34 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
>> rte_eth_dma_zone_reserve()
>>
>> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
>>
>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
>
> Out of curiosity, how did you identify this issue?
These kind of issues are hard not to notice when using shared library
configuration once there's something actually using the symbol. In this
case, the four commits following 719dbebceb81 make the e1000, ixgbe, i40
and fm10k pmds unloadable respectively:
librte_pmd_ixgbe.so: undefined symbol: rte_eth_dma_zone_reserve
Driver autoloading does help unearthing these issues too since all the
pmd's get loaded regardless of the actual hardware present.
- Panu -
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve()
2015-11-18 11:48 ` Mcnamara, John
2015-11-18 12:16 ` Panu Matilainen
@ 2015-11-23 21:22 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-11-23 21:22 UTC (permalink / raw)
To: Panu Matilainen; +Cc: dev
> > Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
> >
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-23 21:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-18 7:33 [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve() Panu Matilainen
2015-11-18 11:48 ` Mcnamara, John
2015-11-18 12:16 ` Panu Matilainen
2015-11-23 21:22 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).